fix(qwik-router): preserve params for ancestor layout loaders - #8945
Draft
ixcans wants to merge 1 commit into
Draft
fix(qwik-router): preserve params for ancestor layout loaders#8945ixcans wants to merge 1 commit into
ixcans wants to merge 1 commit into
Conversation
Keep strict loader events aligned with params matched at each loader's canonical path.
🦋 Changeset detectedLatest commit: f173334 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
This is a narrow follow-up to #8944. Strict loaders intentionally scope an ancestor loader's request event to that loader's own path, but the scoped event currently replaces
paramswith an empty object even when that path resolved dynamic parameters.For example, a loader declared at
/[tenantSlug]/while rendering/acme/agents/should keep its canonical/acme/URL and receive{ tenantSlug: 'acme' }. Parameters introduced below the loader's path remain excluded.Security
This preserves the cache-isolation behavior from #8856. Params come only from the route-trie snapshot captured at the same canonical loader path, and a missing snapshot fails closed to
{}. Search-only scoped events retain their existing empty params behavior.Testing
pnpm fmtpnpm tsc.checkpnpm api.updateenv -u RUSTUP_TOOLCHAIN pnpm build.corepnpm vitest run packages/qwik-router(65 files, 635 tests)/x/sub/renders both loader values as"x"; the ancestor event remains scoped to/x/and receives{ "slug": "x" }pnpm test.unitalso completed 3,235 tests successfully; seven unrelated Qwik Vite plugin tests failed locally because their source-mode optimizer resolved a missing generated binding at/qwik-vite/src/bindings/qwik.wasm.mjs.Changeset
@qwik.dev/router