Skip to content

fix: deprecated event$ - #7407

Closed
sreeisalso wants to merge 19 commits into
QwikDev:mainfrom
sreeisalso:deprecate-event
Closed

fix: deprecated event$#7407
sreeisalso wants to merge 19 commits into
QwikDev:mainfrom
sreeisalso:deprecate-event

Conversation

@sreeisalso

@sreeisalso sreeisalso commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

What is it?

  • Feature / enhancement

Description

deprecated event$ #4452

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@changeset-bot

changeset-bot Bot commented Mar 10, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fe9c9e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Mar 10, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7407
npm i https://pkg.pr.new/@builder.io/qwik-city@7407
npm i https://pkg.pr.new/eslint-plugin-qwik@7407
npm i https://pkg.pr.new/create-qwik@7407

commit: fe9c9e5

@github-actions

github-actions Bot commented Mar 10, 2025

Copy link
Copy Markdown
Contributor
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 401894e

@sreeisalso
sreeisalso marked this pull request as ready for review March 10, 2025 07:59
@sreeisalso
sreeisalso requested review from a team as code owners March 10, 2025 07:59
Comment thread packages/docs/src/routes/api/qwik/api.json Outdated
Comment thread packages/docs/src/routes/api/qwik/index.md Outdated
Comment thread packages/qwik-city/src/runtime/src/spa-init.ts
@wmertens

Copy link
Copy Markdown
Member

Could you also add a changeset?

@sreeisalso

Copy link
Copy Markdown
Contributor Author

Could you also add a changeset?

@wmertens done

@maiieul

maiieul commented Mar 11, 2025

Copy link
Copy Markdown
Member

@PatrickJS I remember you guys are using it in production. Are you fine with deprecating it for now? We don't have to remove it but that kind of dissuades other developers from using it until we figure out whether we should remove it or replace it with something else.

@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development Mar 11, 2025
@sreeisalso
sreeisalso requested a review from wmertens March 20, 2025 14:39
@shairez

shairez commented Mar 25, 2025

Copy link
Copy Markdown
Contributor

Thanks @sreeisalso !

Currently blocked by #6871

@sreeisalso sreeisalso mentioned this pull request Aug 20, 2025
5 tasks
@sreeisalso sreeisalso closed this Aug 20, 2025
@github-project-automation github-project-automation Bot moved this from Waiting For Review to Done in Qwik Development Aug 20, 2025
@sreeisalso

Copy link
Copy Markdown
Contributor Author

see latest at #7843

@sreeisalso
sreeisalso deleted the deprecate-event branch August 20, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants