Skip to content

test: skip flaky post-ROLLBACK COUNT(*) check against postgresql driver #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rustyconover merged 2 commits into from
Aug 27, 2026
Merged

test: skip flaky post-ROLLBACK COUNT(*) check against postgresql driver #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34828ca
test: skip flaky post-ROLLBACK COUNT(*) check against postgresql driver
rustyconover Aug 27, 2026
6dd2fd7
test: widen the postgresql rollback/commit skip to both COUNT(*) checks
rustyconover Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions test/sql/adbc_postgres.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,13 @@ SELECT COUNT(*) FROM pg.public.adbc_pg_big;
50000

# Real transactions: ROLLBACK undoes, COMMIT persists
#
# Flaky against the postgresql ADBC driver: a COUNT(*) issued shortly after a
# ROLLBACK or COMMIT intermittently disagrees with the actual persisted state
# -- and not in a fixed spot, either (it's shown up after the ROLLBACK check
# in one run and after the COMMIT check in another). Filed upstream against
# the driver. Keep exercising BEGIN/INSERT/ROLLBACK/COMMIT themselves, but
# skip verifying the row count immediately afterwards until that's resolved.
statement ok
BEGIN;

Expand All @@ -84,11 +91,15 @@ INSERT INTO pg.public.adbc_pg_big SELECT i, 'x'||i FROM range(100000,100010) t(i
statement ok
ROLLBACK;

mode skip

query I
SELECT COUNT(*) FROM pg.public.adbc_pg_big;
----
50000

mode unskip

statement ok
BEGIN;

Expand All @@ -98,11 +109,15 @@ INSERT INTO pg.public.adbc_pg_big SELECT i, 'y'||i FROM range(100000,100010) t(i
statement ok
COMMIT;

mode skip

query I
SELECT COUNT(*) FROM pg.public.adbc_pg_big;
----
50010

mode unskip

statement ok
DETACH pg;

Expand Down
Loading