Repository navigation
chore: Align Rust toolchain & CI with chain repo - #72
Conversation
| @@ -0,0 +1,50 @@ | |||
| --- | |||
There was a problem hiding this comment.
@czareko you mentioned that CodeQL requires switching from default setup to advanced setup... We should add a merge checklist note or issue link for disabling/switching CodeQL default setup once this workflow lands. Current checks show both “CodeQL on: dynamic” and this new workflow running, so we may double-run CodeQL until the repo setting is changed.
There was a problem hiding this comment.
@ethan-crypto, my comment in the test section was outdated. From the repo perspective, everything is now disabled, and the configuration is fully managed from our code. This way, we can keep it consistent across all projects.
ethan-crypto
left a comment
There was a problem hiding this comment.
Overall looks good. IMO I think we should move continue-on-error: true from the security-audit job to the Run cargo audit step to keep the audit informational while avoiding a failed check in the PR UI.
| needs: fast-checks | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| continue-on-error: true |
There was a problem hiding this comment.
| continue-on-error: true |
| cargo install cargo-audit --locked --version 0.22.1 | ||
| fi | ||
| - name: Run cargo audit (informational only) | ||
| run: cargo audit |
There was a problem hiding this comment.
| run: cargo audit | |
| continue-on-error: true | |
| run: cargo audit |
Summary
Aligns the Rust toolchain and CI configuration with our consumer repo
Quantus-Network/chain, and addstwo non-blocking security signals (
cargo audit+ CodeQL) plus least-privilegepermissions for all workflows.
Changes
1.93.0(matcheschain/rust-toolchain), withtarget
wasm32v1-none. Every CI job now doesrustup showup-front so thepinned toolchain is installed and logged explicitly instead of relying on the
runner's default
stable.🔐 Security Auditjob inci.ymlrunningcargo audit. Markedcontinue-on-error: truebecause all current findings come transitivelythrough the Substrate stack (
sp-runtime 45 → sp-io 44 → ...) and cannotbe fixed from this repo. See follow-up issue for the resolution plan.
.github/workflows/codeql.yml) scanning bothactions(workflow hygiene) andrust(taint/quality) with thesecurity-and-qualityquery set, build-modenone. Mirrors the setupin
qp-rusty-crystals.permissions: contents: readat workflow level inci.yml,create-release-proposal.ymlandcreate-release-tag-and-publish.yml.Per-job
contents: writeoverrides are kept where actually needed (tag push,release creation, version-bump PR).
Notes
chainitself does not runcargo auditand pins the samesp-*versions,so the same vulnerabilities exist there transitively. Tracking long-term
resolution in a separate issue rather than blocking this PR.
wasm32-unknown-unknowntowasm32v1-nonein
rust-toolchainhas no effect on the actual build (no--targetispassed in CI and there is no runtime crate in this workspace) — it is
purely a consistency change with
chain.