perf: Cache serialized extensions to speed up encoding - #3210
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3210 +/- ##
==========================================
- Coverage 81.55% 81.55% -0.01%
==========================================
Files 242 242
Lines 47309 47373 +64
Branches 40906 40970 +64
==========================================
+ Hits 38584 38633 +49
- Misses 6713 6721 +8
- Partials 2012 2019 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 32.63%
Performance Changes
Tip Curious why performance improved? Comment Comparing |
aborgna-q
force-pushed
the
ab/extension-serialization-cache
branch
from
September 1, 2026 13:08
a72ae13 to
6107e9c
Compare
cqc-alec
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the serialized json buffer around when loading an extension in Rust, so we don't need to re-encode them each time.
Extensions are shared inside
Arcs, so the buffer is only stored once.