-
Notifications
You must be signed in to change notification settings - Fork 18
feat: Add configuration settings to mermaid render #3207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicolaassolini-qntm
wants to merge
12
commits into
main
Choose a base branch
from
na/3001-render-ext-ver-mermaid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c1dc023
WIP
nicolaassolini-qntm e0c779f
WIP
nicolaassolini-qntm 3d010da
introduce qualify op name setting
nicolaassolini-qntm 89ce074
update mmmd files
nicolaassolini-qntm 50144e2
add RenderStringConfig parameter to MermaidFormatter
nicolaassolini-qntm 786f81b
printing type args and versions in nodes
nicolaassolini-qntm 3f2ea80
render config for edges too
nicolaassolini-qntm 783115e
fixed mermaid config
nicolaassolini-qntm 01116d7
inlied node
nicolaassolini-qntm 0cdbb5f
little improvements
nicolaassolini-qntm e40a8dd
Merge remote-tracking branch 'origin/main' into na/3001-render-ext-ve…
nicolaassolini-qntm 233cff3
deleted left over
nicolaassolini-qntm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,7 @@ use crate::extension::ExtensionRegistry; | |
| use crate::hugr::internal::{DefaultPGNodeMap, PortgraphNodeMap}; | ||
| use crate::hugr::views::syn_edge::SynEdgeWrapper; | ||
| use crate::metadata::{Metadata, MetadataError, RawMetadataValue}; | ||
| use crate::ops::{OpParent, OpTag, OpTrait, OpType, handle::NodeHandle}; | ||
| use crate::ops::{OpParent, OpTag, OpTrait, OpType, RenderStringConfig, handle::NodeHandle}; | ||
| use crate::types::{EdgeKind, PolyFuncType, Signature, Type}; | ||
| use crate::{Direction, IncomingPort, OutgoingPort, Port}; | ||
|
|
||
|
|
@@ -430,6 +430,14 @@ pub trait HugrView: HugrInternals { | |
| fn mermaid_string(&self) -> String { | ||
| self.mermaid_string_with_formatter(self.mermaid_format()) | ||
| } | ||
| /// Return the mermaid representation of the underlying hierarchical graph | ||
| /// using the provided rendering configuration. | ||
| /// | ||
| /// This method allows customizing the appearance of node labels and other | ||
| /// elements in the mermaid diagram. | ||
| fn mermaid_string_with_config(&self, config: RenderStringConfig) -> String { | ||
| self.mermaid_string_with_formatter(self.mermaid_format().with_render_string_config(config)) | ||
| } | ||
|
|
||
|
Comment on lines
+433
to
441
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if a method like this may be useful |
||
| /// Return the mermaid representation of the underlying hierarchical graph | ||
| /// according to the provided [`MermaidFormatter`] formatting options. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
dot_string()used for real in rust?