WIP: Extend dataflow analysis to handle reachability - #1672

Draft

acl-cqc wants to merge 208 commits into

mainfrom

acl/dataflow_reachability

Commits on Sep 11, 2024

Just const_fold2 + inside that partial_value (taken from hugr_core)
acl-cqc
committed
c7a9d89
merge/update+fmt (ValueName for ConstInt non-compiling as ConstInt not Hash)
acl-cqc
committed
ac45e53
Missing imports / lints. Now running, but failing w/StackOverflow
acl-cqc
committed
8adaa6e
Fix tests...
acl-cqc
committed
098c735
ValueKey using MaybeHash
acl-cqc
committed
706c892
tag() does not refer to self.is_compound
acl-cqc
committed
63bc944
ValueHandle::{is_compound,num_fields,index} => {variant_values, as_sum}
acl-cqc
committed
5fa7edb
Rm ValueHandle::tag, use variant_values - inefficient, presume this is what was meant
acl-cqc
committed
98bf94a
add variant_values, rewrite one use of outputs_for_variant
acl-cqc
committed
295ec32
...and the other two; remove outputs_for_variant
acl-cqc
committed
5c8289e
Rewrite tuple rule to avoid indexing
acl-cqc
committed
bf173ab
GC unused (tuple,variant)_field_value, iter_with_ports
acl-cqc
committed
0ae4d19
Common up via ValueRow.unpack_first
acl-cqc
committed
8608ba9
No DeRef for ValueHandle, just add get_type()
acl-cqc
committed
2dca3e9
ValueKey::{Select->Field,index->field}
acl-cqc
committed
51e68ea
(join/meet)_mut_unsafe => try_(join/meet)_mut with Err for conflicting len
acl-cqc
committed
8635474
Remove ValueHandle::variant_values - just have as_sum
acl-cqc
committed
80d5b86
Optimize as_sum() by returning impl Iterator not Vec
acl-cqc
committed
1c8be99
Machine uses PV not PartialValue
acl-cqc
committed
b0afa54
Parametrize PartialValue+PV+Machine by AbstractValue/Into<Value>, Context interprets load_constant
acl-cqc
committed
d09a1fe
Move partial_value.rs inside datalog/
acl-cqc
committed
af8827b
Hide PartialSum/PartialValue
acl-cqc
committed
4b61436
refactor: ValueRow::single_among_bottoms
acl-cqc
committed
8b31d8c
Factor out propagate_leaf_op; add ValueRow::from_iter
acl-cqc
committed
6a72961
Add handling for Tag
acl-cqc
committed
780af9b
Remove PV (use typedef in datalog.rs)
acl-cqc
committed
cabcf04
Allow DFContext to interpret any leaf op (except MakeTuple/etc.); pub PV+PS
acl-cqc
committed
5e4a04f
Also fold extension ops
acl-cqc
committed
1453886
Comment as_sum
acl-cqc
committed
221e96c
Rename DataflowContext to HugrValueContext
acl-cqc
committed
cd4e15c
Move {datalog=>value_handle}/context.rs - an impl, datalog uses only DFContext
acl-cqc
committed
c5ab2a9
Comment re. propagate_leaf_op
acl-cqc
committed
6c80acf
Hide PartialValue by abstracting DFContext::InterpretableVal: FromSum (==Value)
acl-cqc
committed
636f14d
Use Value::sum, adding FromSum::Err; fmt
acl-cqc
committed
0acdcc5
Cargo.toml: use explicit git= tag for ascent
acl-cqc
committed
1012e0a
Fix rebase: TryHash, UnpackTuple/MakeTuple now in prelude
acl-cqc
committed
6bd8dba
pub ValueRow+Partial(Value/Sum); add TotalContext
acl-cqc
committed
f7d288f
Remove DFContext::hugr(), as_ref() does just as well
acl-cqc
committed
a62eb0f
Move partial_value out of datalog, combine tests; move ValueRow out of utils
acl-cqc
committed
f0ec237
Move FromSum and try_into_value into total_context.rs
acl-cqc
committed
82a3f22
Separate mod dataflow from mod const_fold2
acl-cqc
committed
e6dc114
fmt
acl-cqc
committed
03ff165
TailLoopTermination just examine whatever PartialValue's we have, remove most
acl-cqc
committed
25ed1fb
Drop non-(Bounded)Lattice impls of (join/meet)(_mut),top,bottom
acl-cqc
committed
09911df
doc fixes, remove missing-docs for partial_value...how does it still work
acl-cqc
committed
248fb07
fix all warnings (inc Machine::new() -> impl Default)
acl-cqc
committed
e2ad079
distribute utils.rs -> machine.rs
acl-cqc
committed
95e2dd9
Move dataflow{/datalog=>}/test.rs
acl-cqc
committed
7f1e122
and more warnings
acl-cqc
committed
faff556
fix extension tests
acl-cqc
committed
401354d
Fix doclink, fix DefaultHasher pre-1.76
acl-cqc
committed
c468387
comment conditional test
acl-cqc
committed
88db5b1
Clarify (TODO untested) branches of join_mut
acl-cqc
committed
738b61b
Exploit invariant PartialValue::Value is not a sum (even single known variant)
acl-cqc
committed
8f9c1ed
Exploit invariant more, RIP join_mut_value_handle
acl-cqc
committed
a71ba97
By similar logic, RIP meet_mut_value_handle; assert_(in)variants now unused
acl-cqc
committed
05280a8

Commits on Sep 13, 2024

Commits on Oct 2, 2024

Hide ValueRow (and move into datalog.rs)
acl-cqc
committed
9f1a5cd
Remove PartialSum::unit()
acl-cqc
committed
15e642e
PartialValue is private struct containing PVEnum (with ::Sum not ::PartialSum)
acl-cqc
committed
514af13
variant => new_variant, unit => new_unit
acl-cqc
committed
5d86f46
Simplify PartialOrd for PartialSum, keys(1,2) support cmp
acl-cqc
committed
d8c8140
PartialSum::variant_values does not take `len` (PartialValue:: still does)
acl-cqc
committed
1315685
clippy
acl-cqc
committed
2aaaeb9
Machine::tail_loop_terminates + case_reachable return Option not panic
acl-cqc
committed
5619761
Machine::read_out_wire_value fails with ConstTypeError if there was one
acl-cqc
committed
f3c175c
PartialValue::try_(join|meet)_mut are pub, don't mutate upon failure
acl-cqc
committed
aad2ef0
Remove some commented-out code
acl-cqc
committed
0a8cc12
Expose PartialSum
acl-cqc
committed
bfcd0a6
dataflow has docs! (enforced)
acl-cqc
committed
248fb23
clippy
acl-cqc
committed
5b8654e

Commits on Oct 7, 2024

Commits on Oct 8, 2024

PartialValue proptests: rm TestSumLeafType, replace ValueHandle with TestValue
acl-cqc
committed
1680829
tests: Rename type_check -> check_value
acl-cqc
committed
2a57a15
tidies
acl-cqc
committed
fcfcb6b
Add a couple more proptests, and a TEMPORARY FIX for a BUG pending better answer
acl-cqc
committed
dcaa928
Remove redundant test
acl-cqc
committed
bcacbcc
Refactor TailLoopTermination::from_control_value
acl-cqc
committed
5192ed8
pub TailLoopTermination, rename members, doc
acl-cqc
committed
e21bbd7
Test tidies (and some ALAN wtf? comments)
acl-cqc
committed
22e0192
Use Tag
acl-cqc
committed
cae5e4f
Add TestContext (no interpret_leaf_op), propolutate, avoid HugrValueContext
acl-cqc
committed
3014827
Avoid propolutate by interpreting LoadConstant (only)
acl-cqc
committed
64b9bb7
Revert "Avoid propolutate by interpreting LoadConstant (only)"
acl-cqc
committed
8bc5e12
tiny const_fold2 doc tweaks
acl-cqc
committed
a3a6213
(TEMP) remove const_fold2 module
acl-cqc
committed
a96ab20
Merge remote-tracking branch 'origin/main' into acl/const_fold2
acl-cqc
committed
3051183
(TEMP) Rm total_context
acl-cqc
committed
777694c
clippy
acl-cqc
committed
5a16e6b

Commits on Oct 9, 2024

Better fix for PartialSum::try_meet_mut
acl-cqc
committed
4f31178
true_or_false uses pv_true+pv_false
acl-cqc
committed
2b523c9
Update to ascent 0.7.0, drop fn join/meet as these are now trait-default
acl-cqc
committed
1d2cb9b
Cargo.toml: oops, remove obsolete comment
acl-cqc
committed
ee91bbe
ValueRow cleanups (remove misleading 'pub's)
acl-cqc
committed
e67051f
Refactor: rm tail_node, clone earlier in ValueRow::unpack_first, rm ValueRow::iter
acl-cqc
committed
94cee55
Add datalog for CFG
acl-cqc
committed
5cf5ff0
refactor: follow unpack_first with enumerate
acl-cqc
committed
7381087
Remove comments from test_tail_loop_(iterates_twice->two_iters)
acl-cqc
committed
60e33db
Add a test of tail loop around conditional
acl-cqc
committed
ef4f433
improve that test - loop input is a sum and the variants have different values
acl-cqc
committed
5935489

Commits on Oct 10, 2024

clippy/nth
acl-cqc
committed
b198681
revert accidental changes to hugr-core/src/types.rs (how?!)
acl-cqc
committed
ed30f80
Cleanup conditional, cfg, unpack_first
acl-cqc
committed
3f7808a
Complex CFG that does a not-XOR...but analysis generally says "true or false"
acl-cqc
committed
436b635
Propagate case results to conditional output only if case reached; some test fix
acl-cqc
committed
0374d13
More test cases
acl-cqc
committed
6a2dd9e
refactor as fixture
acl-cqc
committed
a75fee9
clippy
acl-cqc
committed
151e571

Commits on Oct 14, 2024

Revert "Datalog works on any AbstractValue; impl'd by PartialValue for a BaseValue"
acl-cqc
committed
e15b04d
(Re-)remove PVEnum
acl-cqc
committed
dc08f0d
Remove as_sum. AbstractValues are elements not sums
acl-cqc
committed
436dcd2
clippy
acl-cqc
committed
e817bbe
Refactor: remove 'fn input_count'
acl-cqc
committed
b06cfad
Try to fix interpret_leaf_op: cannot use Bottom for output! But ascent borrowing
acl-cqc
committed
fd717be
interpret_leaf_op for ExtensionOps only; LoadConstant via value_from_(custom_)const(_hugr)
acl-cqc
committed
9b17439

Commits on Oct 15, 2024

Correct comment BaseValue -> AbstractValue
acl-cqc
committed
846d1ee
test Hugr now returns (XOR, AND) of two inputs, one case wrongly producing T|F
acl-cqc
committed
328e7f8
BB reachability, fixes!
acl-cqc
committed
da3c05c
Test cases with true_or_false/top, standardize naming (->test_)conditional
acl-cqc
committed
6930ad4
Try to common up by using case_reachable in conditional outputs - 6 tests fail
acl-cqc
committed
0a3e281
Make case_reachable a relation (dropping bool), not lattice - fixes tests
acl-cqc
committed
b1e0bfd
Call (+test)
acl-cqc
committed
355e814
propolutate_out_wires => prepopulate and set in wires in run
acl-cqc
committed
22f3ce8
Rm/inline value_inputs/value_outputs, use UnpackTuple, comments
acl-cqc
committed
68b1d48
Merge remote-tracking branch 'origin/main' into acl/const_fold2
acl-cqc
committed
77a5fa3
clippy
acl-cqc
committed
2cc62f0
docs
acl-cqc
committed
8254771

Commits on Oct 21, 2024

Commits on Oct 22, 2024

Use ascent_run to drop context from all the relations. Lots cleanup to follow
acl-cqc
committed
ada7ee1
DFContext does not Deref, pass Hugr separately
acl-cqc
committed
7c02d41
Massively reduce scope of clippy-allow to inside run_datalog
acl-cqc
committed
3d4f016
Move ValueRow into own file
acl-cqc
committed
8bab4d5
Move Machine into datalog.rs, pub(super) fields in AnalysisResults, rm DatalogResults
acl-cqc
committed
3eccadf
Move machine.rs to results.rs
acl-cqc
committed
0f4fa52
Remove enum IO, replace io_node -> input_child/output_child
acl-cqc
committed
caa8aca
move docs
acl-cqc
committed
e7f61fc
Remove/inline/dedup dfb_block
acl-cqc
committed
811802c
relation doc
acl-cqc
committed
3713ea7
datalog docs (each relation), move _cfg_succ_dest
acl-cqc
committed
d317809
comment, use exactly_one
acl-cqc
committed
69c3270

Commits on Oct 23, 2024

Allow to handle LoadFunction
acl-cqc
committed
dc56686
doc
acl-cqc
committed
33a8592
Separate out ConstLoader
acl-cqc
committed
b153ada
value_from_(custom_const=>opaque), taking &OpaqueValue
acl-cqc
committed
5052ac0

Commits on Oct 28, 2024

Commits on Oct 29, 2024

And back to Deref, should allow using a region view not the whole Hugr
acl-cqc
committed
87eb700

Commits on Oct 30, 2024

fix doclink
acl-cqc
committed
a49221b
PartialSum::try_into_value also uses Option<...> as error-type
acl-cqc
committed
71ea55d
Proper errors from try_into_value, Option<Extr...> from try_read_wire_value
acl-cqc
committed
ea9db2e
fmt
acl-cqc
committed
df31523
Add test running on region
acl-cqc
committed
a490874
fix: provide PartialValue::Top for unspecified Hugr inputs
acl-cqc
committed
3af39aa
try_into_value allows TryFrom by giving ExtractValueError *2* errortype params
acl-cqc
committed
dc15999
improve docs
acl-cqc
committed
2d81264
Parametrize Machine::try_read_wire_value the same way
acl-cqc
committed
b61d252
tweaks
acl-cqc
committed
8cac194

Commits on Nov 4, 2024

Massively simplify xor_and_cfg, no need for conditionals
acl-cqc
committed
fb3816e
Use tru/fals constants
acl-cqc
committed
19571f6

Commits on Nov 8, 2024

try_into_value: reorder type params, separate out where clause
acl-cqc
committed
69d0f5e
Merge remote-tracking branch 'origin/main' into HEAD
acl-cqc
committed
cb60b5b
We don't actually use portgraph, nor downcast-rs
acl-cqc
committed
2624ee8
Import RandomState from std::collections::hash_map for rust 1.75
acl-cqc
committed
ec526e8
Use BREAK_TAG/CONTINUE_TAG
acl-cqc
committed
5650ee4
No, use make_break/make_continue for easy cases
acl-cqc
committed
da2981c

Commits on Nov 14, 2024

Refactor bb_reachable using then
acl-cqc
committed
0b68454
ConstLocation with Box - a lot of cloning
acl-cqc
committed
4916e9d
No - Revert - just make ConstLocation store a reference
acl-cqc
committed
a4a64c0
{value=>partial}_from_const, takes ConstLoc, inline traverse_value
acl-cqc
committed
bc39b76
Make ConstLocation Copy
acl-cqc
committed
92669db
ConstLocation is From<Node>; move partial_from_const out to toplev, no value_from_const
acl-cqc
committed
33c8607

Commits on Nov 18, 2024

Commits on Nov 19, 2024

Revert "Shorten further...not as easy to follow"
acl-cqc
committed
39b8df1
doc fixes, rename to run_library
acl-cqc
committed
a5d987c
Add PartialValue::contains_bottom, also row_contains_bottom
acl-cqc
committed
3e718fd
Don't call interpret_leaf_op if row_contains_bottom
acl-cqc
committed
497686a
Use row_contains_bottom for CFG+DFG, and augment unpack_first(=>_no_bottom)
acl-cqc
committed
e34c7be
run_library => publish_function
acl-cqc
committed
69a69f3
Drop publish_function, pub prepopulate_wire
acl-cqc
committed
57ac432
ValueRow::single_known => singleton, set
acl-cqc
committed
f9a9f24
try_join / try_meet return extra bool
acl-cqc
committed
9cc368d
shorten/common-up meet_mut + join_mut
acl-cqc
committed
a61fbdb
try_into_value: change bounds TryFrom -> TryInto; rename =>try_into_sum
acl-cqc
committed
24cce0e
Avoid a clone in try_into_sum
acl-cqc
committed
a590766
Optimize+shorten join_mut / meet_mut via std::mem::swap
acl-cqc
committed
2b2c461
refactor join_mut / meet_mut again, common-up assignment
acl-cqc
committed
124718d
clippy
acl-cqc
committed
93b1f4d
doclinks
acl-cqc
committed
731a3b0
prepopulate_df_inputs
acl-cqc
committed
7040e83

Commits on Nov 20, 2024