Skip to content

Prefer useMemo over state + effect. #4598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dnoneill merged 2 commits into from
Oct 14, 2026
Merged

Prefer useMemo over state + effect. #4598

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d76a395
Prefer `useMemo` over state + effect.
cbeer Oct 14, 2026
470ea86
Update src/components/FullScreenButton.jsx
cbeer Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/components/FullScreenButton.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useContext, useEffect, useState } from 'react';
import { useContext, useMemo, useState } from 'react';
Comment thread
cbeer marked this conversation as resolved.
Resolved
import FullscreenIcon from '@mui/icons-material/FullscreenSharp';
import FullscreenExitIcon from '@mui/icons-material/FullscreenExitSharp';
import PropTypes from 'prop-types';
Expand All @@ -13,12 +13,10 @@ export function FullScreenButton({ className = undefined }) {
const handle = useContext(FullScreenContext);

// iPhone Safari does not support full screen on divs,
// Don't render the button if not supported
const [canFullscreenDiv, setCanFullscreenDiv] = useState(false);

useEffect(() => {
// Don't render the button if not supporte
const canFullscreenDiv = useMemo(() => {
const div = document.createElement('div');
setCanFullscreenDiv(typeof div.requestFullscreen === 'function');
return typeof div.requestFullscreen === 'function';
}, []);

if (!canFullscreenDiv) return null;
Expand Down
Loading