Add a getter for the selected carrier billing option - #1104
Merged
Progi1984 merged 1 commit intoAug 21, 2026
Conversation
getBillingSelection returns which shipping method radio is checked on the carrier form, so campaigns can assert that the billing option is preserved when the edit page is reloaded — in particular the new 'Based on the shop configuration' option round-trip.
Contributor
Author
|
@Progi1984 new getter to check the shipping method value, and assert that we can correctly use the default value (there was a bug that made the ObjectModel lost it, fixed in PrestaShop/PrestaShop#42022 and a new UI test checks this new value can be correctly used) |
Progi1984
approved these changes
Aug 21, 2026
github-project-automation
Bot
moved this from Ready for review
to Merged
in PR Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PrestaShop/PrestaShop#42022 makes the
Based on the shop configurationshipping method round-trip through the BO carrier form, and its UI test needs to assert that the option is still selected when the edit page is reloaded. The carrier create page exposed no way to read the current billing selection.What
getBillingSelection(page)on the BO carrier create page returns which shipping method radio is currently checked, using the same value-based selectors introduced by Select carrier shipping method radios by value instead of index #1102 (stable across PrestaShop versions).BOCarriersCreatePageInterfaceso campaigns can use it through the typed interface.