Pin PrestaShop 9.1.4 in CI instead of 9.1.x branch - #1278
Open
kpodemski wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9.1.4tag instead of the9.1.xbranch, which is about to be closed. Also renamestests/php/phpstan/phpstan-9.1.x.neontophpstan-9.1.4.neon, because the workflow derives the PHPStan config filename from the matrix value (phpstan-config: tests/php/phpstan/phpstan-${{ matrix.presta_version }}.neon) — without the rename the job would fail on a missing config. This matches the existingphpstan-9.0.3.neon, which is already pinned to a tag.PHPStan (PHP 8.1 - 8.5)jobs that previously ran against9.1.xmust now show9.1.4in their matrix names and be green. No job should reference9.1.xany more. The9.0.3,developand8.2.xjobs are untouched.Only CI configuration is affected — no module code changes.
The
9.1.xstring still appears once, in a comment that describes which PHP versions the branch family supports; it has been reworded to# PrestaShop 9.1.x (pinned to the 9.1.4 tag) and develop support PHP 8.1 up to 8.5so it stays accurate.