Skip to content

Fix price indexation loop stopping early with non-sequential product ids #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boo-code wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix price indexation loop stopping early with non-sequential product ids #1258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ps_facetedsearch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1583,7 +1583,11 @@ private function indexPrices($cursor = 0, $full = false, $ajax = false, $smart =
$time_elapsed = microtime(true) - $startTime;
$indexedProducts += $length;
} while (
$cursor < $nbProducts
// $cursor is the last indexed id_product (returned by indexPricesUnbreakable()), not a
// counter, so comparing it to the product count is wrong: with non-sequential ids (gaps
// from deleted/imported products) it stops batching as soon as an id exceeds $nbProducts.
// Track how many products were actually indexed instead.
$indexedProducts < $nbProducts
&& (Tools::getMemoryLimit() == -1 || Tools::getMemoryLimit() > memory_get_peak_usage())
&& $time_elapsed < $maxExecutiontime
);
Expand Down
Loading