Skip to content

Fix add, edit and delete filter template link without token - #1240

Open
mgielecinski wants to merge 5 commits into
PrestaShop:devfrom
mgielecinski:fix/bad-edit-and-delete-filter-template-link
Open

Fix add, edit and delete filter template link without token#1240
mgielecinski wants to merge 5 commits into
PrestaShop:devfrom
mgielecinski:fix/bad-edit-and-delete-filter-template-link

Conversation

@mgielecinski

@mgielecinski mgielecinski commented Jun 11, 2026

Copy link
Copy Markdown
Questions Answers
Description? After disabling BO tokens, links to add, edit or delete the filter template are broken because they were always added as NEXT parameters after the token that also added the beginning of the query string.

Before:
../modules/manage/action/configure/ps_facetedsearch&edit_filters_template=1&id_layered_filter=1

After:
../modules/manage/action/configure/ps_facetedsearch?edit_filters_template=1&id_layered_filter=1
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #1228
How to test? 1. Go to Advanced Parameters -> Security
2. Disable BO token
3. Go to the module
4. Try edit/remove any filter template
Sponsor company

Before:
obraz

@ps-jarvis

Copy link
Copy Markdown

Hello @mgielecinski!

This is your first pull request on ps_facetedsearch repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Jun 11, 2026

@kpodemski kpodemski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to use $link in template files. Please make sure that there's either $template.edit_url available and URL is built from the PHP file 👍🏻

@ps-jarvis ps-jarvis added the waiting for author Waiting for author's feedback label Jun 19, 2026
@mgielecinski

Copy link
Copy Markdown
Author

Hello @kpodemski
It will be ok now ? 😏

@mgielecinski
mgielecinski requested a review from kpodemski June 19, 2026 11:09
@ps-jarvis ps-jarvis added the Waiting for QA Status: Action required, Waiting for test feedback label Jun 22, 2026
@kpodemski kpodemski removed the waiting for author Waiting for author's feedback label Jun 22, 2026
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Jun 22, 2026
@kpodemski kpodemski added the Waiting for QA by Community Status: Action required, Waiting for test feedback by Community label Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for QA by Community Status: Action required, Waiting for test feedback by Community Waiting for QA Status: Action required, Waiting for test feedback

Projects

Status: To be tested

Development

Successfully merging this pull request may close these issues.

Error created new template

3 participants