chore: minor fixes and cleanup - #999
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
More cleanup to make ornithe port easier
The only functional change is a fix to
Mixin_SoundPlayedEventwhich was ported wrongly in 89dbc43c. TheModifyVariablemixin should return the modified sound, previously the original sound was always played.>= 26.3condition for its updated callback descriptor LWJGL/lwjgl3@e28dd69fabric-apidependency infabric.mod.jsonfrom the bootstrap module to the minecraft module, so the bootstrap one is modloader independent. Dependency resolution is transitive so this is fineRelated Issue(s)
Checklist