Derive Clone on all enums and structs + loosen requirements for instance_domain - #13
Open
benthillerkus wants to merge 7 commits into
Open
Derive Clone on all enums and structs + loosen requirements for instance_domain#13benthillerkus wants to merge 7 commits into
Clone on all enums and structs + loosen requirements for instance_domain#13benthillerkus wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still figuring things out, but these are the changes I needed to make for my project so far.
If there is interest in merging only parts, I can split them up, as I guess the
Copyon theenums might not be desired for forwards compatibility and changing the signature oninstance_domainis a breaking change.