Fix broken Drivers JavaDoc nav link - #91
Merged
Merged
Conversation
The Drivers JavaDoc entry rendered as an empty anchor (<a href="">) in
the sidebar nav. The learn theme's menu partial only honors the
externalUrl front-matter param for section pages (menu.html line 116);
leaf pages fall back to <a href="{{ .RelPermalink }}"> (line 152), which
is empty here because the page uses build.render: never.
Convert the leaf page to a section _index.md, matching the working
"Core and Plugins JavaDoc" entry (content/api-javadoc/_index.md), so the
externalUrl is honored and the link points to the JavaDoc site.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Drivers JavaDoc entry in the sidebar nav rendered as an empty anchor (
<a href="">, i.e.<>).Root cause: the learn theme's
menu.htmlonly honors theexternalUrlfront-matter param for section pages (line 116). Leaf pages fall back to<a href="{{ .RelPermalink }}">(line 152), which is empty here because the page usesbuild.render: never.Fix: convert the leaf page to a section by renaming
content/drivers/drivers-javadoc.md→content/drivers/drivers-javadoc/_index.md, matching the working "Core and Plugins JavaDoc" entry (content/api-javadoc/_index.md). No content or theme changes.Test plan
hugobuilds clean; the rendered nav now emits<a href="https://apidia.net/mvn/com.pi4j/pi4j-drivers/" target="_blank" rel="noopener">.🤖 Generated with Claude Code