Repository navigation
fix: update after ControlledPhaseShift produces GlobalPhase in decomp - #717
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## sc-127668-runners #717 +/- ##
===================================================
Coverage 100.00% 100.00%
===================================================
Files 9 9
Lines 873 873
===================================================
Hits 873 873 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
* Fix GlobalPhase compatibility with PennyLane main * Link GlobalPhase changelog entry to PR 724
JerryChen97
added a commit
that referenced
this pull request
Oct 23, 2026
* adding concurrency group * cleanup * xfail test to unblock PR * Update tests/test_base_device.py Co-authored-by: Alex Preciado <26556730+Alex-Preciado@users.noreply.github.com> * Trigger Build * Trigger Build * Trigger Build * fix: update after `ControlledPhaseShift` produces `GlobalPhase` in decomp (#717) * fix: update after ControlledPhaseShift produces GlobalPhase in decomposition * remove xfail * Fix GlobalPhase compatibility with PennyLane main (#724) * Fix GlobalPhase compatibility with PennyLane main * Link GlobalPhase changelog entry to PR 724 --------- Co-authored-by: Yushao Chen (Jerry) <chenys13@outlook.com> * Trigger CI * Trigger Build --------- Co-authored-by: andrijapau <andrija.paurevic@xanadu.ai> Co-authored-by: Alex Preciado <26556730+Alex-Preciado@users.noreply.github.com> Co-authored-by: Andrija Paurevic <46359773+andrijapau@users.noreply.github.com> Co-authored-by: Yushao Chen (Jerry) <chenys13@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ControlledPhaseShift is now an Operator2 whose decomposition now has GlobalPhase in it.
The test is asserting that the decomposed ops below in QISKIT_OPERATION_MAP (which excludes GlobalPhase). However, the device accepts GlobalPhase as it is explcitly added in device.operations. E2E execution isn't affected.
Simply improve the test,