Repository navigation
Harden chapter 7–11 companion examples and release checks - #48
Merged
Merged
Conversation
salim4n
marked this pull request as ready for review
October 12, 2026 16:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coordinates issues #32-#46 through tracking issue #47. This PR remains a draft until external acceptance is proven.
Implemented in this review pass: successful STDIO responses and registered-tool invalid-input tests; missing-price guards; process-cold benchmark mode; an authenticated owner-bound approval/checkpoint path with approve/reject, stale-decision and pending-start protection; explicit verified TLS parameters for Drizzle migrations and checkpoint connections. The #42 synthetic side-effect counter, owner, replay and restart acceptance tests pass. The current travel search tools are read-only; booking is explicitly a future extension in #42. Any future effectful production tool must provide a business idempotency key before registration.
Verified on head ca89229: GitHub Actions run 35983299263 passed frozen install, STDIO and HTTP MCP checks, Travel AI lint/types/57 tests/build on Node 20.20.2. Separately, local isolated PostgreSQL accepted a trusted test CA and rejected an untrusted CA for both migrations and checkpoint connection. Local tests and synthetic approval tools do not prove live provider or deployment behavior.
Outstanding external acceptance: #34/#41 live-provider benchmark and quality/cost evidence; #38 deployed MCP endpoint; #44/#45 clean Vercel preview plus authenticated chat/retrieval/persistence smoke. No deployment exists for this head. Keep the PR draft and keep unmet issues open.