Beta v11.3.0 - #105
Beta v11.3.0#105
Conversation
- 将项目简介格式调整为更清晰的标题样式 - 添加了完整的文档导航表格和高级教程链接 - 重新组织快速开始部分，分为在线安装和离线使用说明 - 更新警告提示的位置和格式 - 移除重复的社区链接部分 - 修改赞助档位描述，移除按月订阅表述 - 强调免责声明中的重要提醒 - 更新 CNB.COOL 鸣谢部分的格式 - 优化整体文档布局和可读性 feat(PVE-Tools.sh): 更新下载源名称与品牌标识 - 将源名称从 "CNB 国内源" 更改为 "CNB.COOL 国内源" - 添加 CNB.cool 感谢信息显示 - 在下载过程中展示品牌合作信息
- 将封面图片从 cover.svg 更改为 main.png - 移除多语言 README 链接表格 - 简化 CDN 服务提供商展示方式，直接使用图片标签替代表格布局 - 优化文档结构和视觉呈现效果
Reviewer's Guide本 PR 主要围绕 Beta v11.3.0 的项目发布信息与分发体验进行更新：重写中文 README、移除英文文档，并将启动器的国内下载源品牌及提示统一更新为 CNB.cool。 Sequence diagram for the CNB.cool-first download flowsequenceDiagram
participant User
participant Launcher as PVE_Tools.sh
participant CNB as CNB_cool
participant GitHub as GitHub_Releases
User->>Launcher: pve_tools_entry_download_file()
Launcher->>CNB: Download PVE-Tools.sh
alt CNB.cool download succeeds
CNB-->>Launcher: Complete program
else CNB.cool download fails
Launcher->>GitHub: Download PVE-Tools.sh
GitHub-->>Launcher: Complete program
end
Launcher-->>User: Run downloaded program
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pull request rewrites the Chinese README, removes the English README, and updates download output to identify and thank CNB.cool. ChangesDocumentation and messaging
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="README.md" line_range="75" />
<code_context>
-wget https://github.com/PVE-Tools/PVE-Tools-9/releases/latest/download/PVE-Tools.sh
-chmod +x PVE-Tools.sh
-sudo ./PVE-Tools.sh
+wget https://raw.githubusercontent.com/PVE-Tools/PVE-Tools-9/latest/download/PVE-Tools.sh
```
</code_context>
<issue_to_address>
**issue:** The documented international download URL uses `raw.githubusercontent.com/.../latest/download/...`, where `latest` is interpreted as a Git branch and `download/PVE-Tools.sh` as a repository path; GitHub Releases assets are served from `github.com/.../releases/latest/download/...`, so this command returns 404 instead of downloading the launcher.
**Triggers:** When an international user follows the offline-use instructions.
**Suggested fix:** Use `https://github.com/PVE-Tools/PVE-Tools-9/releases/latest/download/PVE-Tools.sh`, matching `PVE_TOOLS_REMOTE_DIST_URL` in the launcher.
```suggestion
wget https://github.com/PVE-Tools/PVE-Tools-9/releases/latest/download/PVE-Tools.sh
```
</issue_to_address>
### Comment 2
<location path="README.md" line_range="70" />
<code_context>
+**中国大陆用户**
```bash
-bash <(curl -sSL https://github.com/PVE-Tools/PVE-Tools-9/releases/latest/download/PVE-Tools.sh)
+wget https://cnb.cool/PVE-Tools/PVE-Tools-Pro/-/git/raw/main/PVE-Tools.sh
```
</code_context>
<issue_to_address>
**issue:** The China download command fetches `main/PVE-Tools.sh`, which is the launcher rather than the complete program; running it still downloads `dist/PVE-Tools.sh` from a remote source, so the section does not provide an offline-use procedure and fails when the machine has no subsequent network access.
**Triggers:** When a user interprets the new “离线使用” section as downloading once and running without network access.
**Suggested fix:** Provide a link to the built `dist/PVE-Tools.sh` artifact and document that artifact as the offline package, or rename the section to describe manual launcher download.
```suggestion
wget https://cnb.cool/PVE-Tools/PVE-Tools-Pro/-/git/raw/dist/PVE-Tools.sh
```
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: README.md:75, README.md:70
| wget https://github.com/PVE-Tools/PVE-Tools-9/releases/latest/download/PVE-Tools.sh | ||
| chmod +x PVE-Tools.sh | ||
| sudo ./PVE-Tools.sh | ||
| wget https://raw.githubusercontent.com/PVE-Tools/PVE-Tools-9/latest/download/PVE-Tools.sh |
There was a problem hiding this comment.
issue: The documented international download URL uses raw.githubusercontent.com/.../latest/download/..., where latest is interpreted as a Git branch and download/PVE-Tools.sh as a repository path; GitHub Releases assets are served from github.com/.../releases/latest/download/..., so this command returns 404 instead of downloading the launcher.
Triggers: When an international user follows the offline-use instructions.
Suggested fix: Use https://github.com/PVE-Tools/PVE-Tools-9/releases/latest/download/PVE-Tools.sh, matching PVE_TOOLS_REMOTE_DIST_URL in the launcher.
| wget https://raw.githubusercontent.com/PVE-Tools/PVE-Tools-9/latest/download/PVE-Tools.sh | |
| wget https://github.com/PVE-Tools/PVE-Tools-9/releases/latest/download/PVE-Tools.sh |
| **中国大陆用户** | ||
| ```bash | ||
| bash <(curl -sSL https://github.com/PVE-Tools/PVE-Tools-9/releases/latest/download/PVE-Tools.sh) | ||
| wget https://cnb.cool/PVE-Tools/PVE-Tools-Pro/-/git/raw/main/PVE-Tools.sh |
There was a problem hiding this comment.
issue: The China download command fetches main/PVE-Tools.sh, which is the launcher rather than the complete program; running it still downloads dist/PVE-Tools.sh from a remote source, so the section does not provide an offline-use procedure and fails when the machine has no subsequent network access.
Triggers: When a user interprets the new “离线使用” section as downloading once and running without network access.
Suggested fix: Provide a link to the built dist/PVE-Tools.sh artifact and document that artifact as the offline package, or rename the section to describe manual launcher download.
| wget https://cnb.cool/PVE-Tools/PVE-Tools-Pro/-/git/raw/main/PVE-Tools.sh | |
| wget https://cnb.cool/PVE-Tools/PVE-Tools-Pro/-/git/raw/dist/PVE-Tools.sh |
1 participant
Summary by Sourcery
Refresh project documentation and download-source messaging for the v11.3.0 release.
Enhancements:
Documentation:
Summary by CodeRabbit