Fix nicknames on modern#106
Merged
Merged
Conversation
calcastor
force-pushed
the
nicks
branch
2 times, most recently
from
March 3, 2026 04:21
cc97ad9 to
bd3058d
Compare
calcastor
marked this pull request as draft
March 3, 2026 04:29
calcastor
marked this pull request as ready for review
April 14, 2026 23:12
calcastor
force-pushed
the
nicks
branch
6 times, most recently
from
April 15, 2026 06:03
e1612c2 to
409b250
Compare
applenick
approved these changes
Apr 15, 2026
calcastor
marked this pull request as draft
April 23, 2026 09:47
calcastor
force-pushed
the
nicks
branch
3 times, most recently
from
May 2, 2026 05:46
c5ab043 to
64cba7d
Compare
calcastor
force-pushed
the
nicks
branch
6 times, most recently
from
May 7, 2026 05:56
fab15b5 to
98542fb
Compare
Signed-off-by: BT <43831917+calcastor@users.noreply.github.com>
Signed-off-by: BT <43831917+calcastor@users.noreply.github.com>
Signed-off-by: BT <43831917+calcastor@users.noreply.github.com>
a Signed-off-by: BT <43831917+calcastor@users.noreply.github.com>
Signed-off-by: applenick <applenick@users.noreply.github.com>
calcastor
marked this pull request as ready for review
May 11, 2026 06:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires PGMDev/PGM#1655
changes I made in 36afff5 to PacketManipulations are incorrect and this fixes that, in part because PacketEvents makes it harder to be wrong