Repository navigation
Rename to goodmem-nlweb / goodmem_nlweb, release 0.3.0 - #5
Merged
Merged
Conversation
The package moves into the PAIR Systems (pairsysai) organization on PyPI, under the new distribution name goodmem-nlweb. The import package stays nlweb_goodmem, so imports and NLWeb's `import_path: nlweb_goodmem` config entries are unchanged. nlweb-goodmem stays at 0.2.2. - pyproject: name goodmem-nlweb, version 0.2.3; __version__ 0.2.3 - ci.yml: smoke-install dist/goodmem_nlweb-*.whl - publish.yml: environment url and pending-publisher setup comment - README: install line and a note on the old name; CHANGELOG 0.2.3 - test_e2e: throwaway space label follows the new name release-on-merge.yml reads the name from pyproject.toml, so its PyPI check follows the rename without an edit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both distributions ship the nlweb_goodmem import package, so having both installed makes them overwrite each other's files; uninstalling the old one afterwards removes nlweb_goodmem entirely (ModuleNotFoundError). README and CHANGELOG now say to run `pip uninstall -y nlweb-goodmem && pip install goodmem-nlweb`. CHANGELOG states the reason for the rename: the move into the PAIR Systems PyPI organisation under the goodmem-<framework> naming used by goodmem-adk and goodmem-semantic-kernel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Distribution goodmem-nlweb now imports as goodmem_nlweb, the goodmem-<framework> / goodmem_<framework> naming used by goodmem-adk and goodmem-semantic-kernel. Breaking: `import nlweb_goodmem` becomes `import goodmem_nlweb`, and NLWeb provider entries change from `import_path: nlweb_goodmem` to `import_path: goodmem_nlweb`. - git mv src/nlweb_goodmem -> src/goodmem_nlweb; every import, the hatch wheel/sdist paths, [tool.mypy] packages, the CI smoke import, the caplog logger name, README code and YAML samples, and the docstring YAML that tests/test_config.py loads through nlweb-core - version 0.3.0 (minor: the import path change is breaking) - README: drop the "previously published as" / uninstall note - CHANGELOG: one 0.3.0 entry replaces the unreleased 0.2.3 entry; older entries keep the old import name as history Metadata keys stored on the server (url, site, schema_json) are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames this integration to the
goodmem-<framework>naming used bygoodmem-adkandgoodmem-semantic-kernel, published inside the PAIR Systems (pairsysai) PyPI organisation. Version 0.3.0. The version is a minor bump because the import path change is breaking.main, 0.2.2)nlweb-goodmemgoodmem-nlwebnlweb_goodmemgoodmem_nlwebimport_pathnlweb_goodmemgoodmem_nlwebWhat changes for users
pip install goodmem-nlweb.from goodmem_nlweb import GoodMemRetrievalProvider, GoodMemObjectLookupProvider, upload_documentsreplaces the old import. There is no compatibility shim.import_path, so provider entries become:object_storage.default).url,site,schema_json) are unchanged, so existing spaces read exactly as before.nlweb-goodmemstays at 0.2.2 on PyPI.Before merging
This repo has
release-on-merge.yml: merging this PR publishes immediately. When CI passes onmain, it tags the mergev0.3.0and dispatchespublish.yml, which uploads via Trusted Publishing. The pending publisher forgoodmem-nlwebmust exist on PyPI first, or the publish job fails.In the
pairsysaiorganisation on PyPI, go to Publishing and choose "Add a new pending publisher". Enter these values, read from this repo:goodmem-nlwebPAIR-Systems-Incgoodmem_nlwebpublish.ymlpypirelease-on-merge.ymlreadsnameandversionfrompyproject.toml, so its PyPI check querieshttps://pypi.org/pypi/goodmem-nlweb/0.3.0/json. That URL returns 404 today, so the release will publish. The tagv0.3.0does not exist yet.Changes
src/nlweb_goodmem/→src/goodmem_nlweb/(git mv). All internal imports are updated.pyproject.toml:name = "goodmem-nlweb",version = "0.3.0", hatch wheelpackagesand sdistincludepaths, and[tool.mypy] packages.__version__ = "0.3.0"..github/workflows/ci.yml: the clean-env smoke test installsdist/goodmem_nlweb-*.whland runsfrom goodmem_nlweb import …..github/workflows/publish.yml: environment URLhttps://pypi.org/project/goodmem-nlweb/, plus the pending-publisher setup comment.README.md: title, install line, the YAMLimport_path(retrieval and object_storage) and the Python samples.__init__.pyandprovider.pycarry the YAMLimport_path: goodmem_nlweb.tests/test_config.pyloads those docstrings and the README YAML with nlweb-core's ownload_config/initialize_providers, so the newimport_pathis exercised for real.caploglogger name (goodmem_nlweb.provider; the module useslogging.getLogger(__name__)), the throwaway e2e space label, and the regression-suite docstring.examples/nlweb_provider.py: import.CHANGELOG.md: one 0.3.0 entry (renamed; breaking: update imports andimport_path). Older entries keep the old name as history.Grep for
nlweb[-_. ]?goodmem(case-insensitive) has 5 hits, all inCHANGELOG.md: the 0.3.0 entry names the old import in its "update from" instructions (2 lines), and 3 lines in older history entries are left as written.What failed before, and how it behaves now
Before (
main):After (this branch):
pip install goodmem-nlwebworks from PyPI once this is merged and published.Local CI, run the way
ci.ymlruns it from a fresh venv:ruff check src tests examplesis clean,mypyis clean (9 files), andpytest -m "not integration"gives 194 passed, 1 skipped. Also run:bash -non everyrun:block of the three workflows, and thegm_key scan over the tree and the diff (both clean).🤖 Generated with Claude Code