Repository navigation
feat!: rename to goodmem-camel / import goodmem_camel (0.4.0) - #4
Merged
Merged
Conversation
…l_goodmem The distribution moves from `camel-goodmem` to `goodmem-camel` so it can be published from the PAIR Systems organization on PyPI; the old name's only owner is a personal account that cannot be reached. `camel-goodmem` stays at 0.3.0. The import package is unchanged. - pyproject: name = "goodmem-camel", version 0.3.1, and [tool.flit.module] name = "camel_goodmem" -- without it flit derives the module from the new name and the build fails with "No file/folder found for module goodmem_camel". - camel_goodmem.__version__ = "0.3.1". - publish.yml: environment url is pypi.org/project/goodmem-camel/; the setup comment names the real pending-publisher values. - README: title, install line, a rename note near the top, and a "Changes in 0.3.1" table. - examples: space names follow the new name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both distributions ship the same `camel_goodmem` package. Measured: with camel-goodmem 0.3.0 and goodmem-camel 0.3.1 installed together, `pip uninstall camel-goodmem` deletes camel_goodmem while goodmem-camel 0.3.1 is still listed, and `import camel_goodmem` raises ModuleNotFoundError. `pip uninstall -y camel-goodmem && pip install goodmem-camel` imports 0.3.1. The rename note, the install section and the 0.3.1 changes say so. The 0.3.1 entry now gives the reason as the move into the PAIR Systems PyPI organization under the goodmem-<framework> naming used by goodmem-adk and goodmem-semantic-kernel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follows the goodmem-<framework> / goodmem_<framework> convention of goodmem-adk and goodmem-wandb: distribution `goodmem-camel`, import package `goodmem_camel`. Breaking: `import camel_goodmem` becomes `import goodmem_camel`. No compatibility shim. - git mv camel_goodmem -> goodmem_camel; every import, Sphinx cross-ref, error message, test, example, CI target (ruff/mypy/import checks, the TLS gate's find path) and README sample follows. - pyproject: drop the [tool.flit.module] block -- flit's default module name now matches the distribution; version 0.4.0 (v0.4.0 does not exist; v0.3.0 does). - README: drop the "previously published as" / uninstall notes; one "Changes in 0.4.0" entry states the rename and the breaking import. - Loggers are get_logger(__name__), so they become camel.goodmem_camel.* with no code change. CAMEL's @MCPSERVER names the server after the class (GoodMemToolkit), not the module, so it is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the package to
goodmem-camel, imported asgoodmem_camel, and bumps it to 0.4.0. This follows the convention of goodmem-adk (import goodmem_adk) and goodmem-wandb (import goodmem_wandb): the distribution isgoodmem-<framework>and the import package isgoodmem_<framework>. The package is published in the PAIR Systems PyPI organization (pairsysai).What changes for users
pip install goodmem-camel.camel_goodmemtogoodmem_camel, for examplefrom goodmem_camel import GoodMemToolkit, GoodMemRetriever, filters. There is no compatibility shim; we assume the package has no users yet.camel-goodmem, stays at 0.3.0 on PyPI.goodmem_search,goodmem_remember, …), the MCP server name (GoodMemToolkit) and the request payloads are all the same.get_logger(__name__), so they are nowcamel.goodmem_camel.*instead ofcamel.camel_goodmem.*.Changes
git mv camel_goodmem goodmem_camel. Every reference to the old name was updated:filterserror message;ci.ymltargets: ruff, mypy, the clean-venv and floors import checks, and the TLS gate'sfindpath.pyproject.toml:name = "goodmem-camel"andversion = "0.4.0".[tool.flit.module]block. flit's default module name (derived from the distribution name) is nowgoodmem_camel, which matches.publish.yml: the environment URL ishttps://pypi.org/project/goodmem-camel/, and the setup comment names the real pending-publisher values.README.md: the title, install line and code samples use only the new names, and there is one Changes in 0.4.0 entry.examples/example_usage.py: the space names are nowgoodmem-camel-example*.@MCPServer()decorator names the FastMCP server aftercls.__name__and never uses the module path. After the rename,GoodMemToolkit.__module__isgoodmem_camel.toolkit,tk.mcp.nameisGoodMemToolkit, and the MCP tools are['goodmem_remember', 'goodmem_search'].Before merging
This repo is tag-only. There is no
release-on-merge.yml, so merging does not publish.publish.ymlpublishes when av*tag is pushed. After merge, publishing happens whenv0.4.0is tagged on the merge commit. That tag does not exist yet;v0.3.0does.Before that tag is pushed, the pending trusted publisher for
goodmem-camelmust exist on PyPI in thepairsysaiorg. Otherwise the publish job fails at the upload step. Enter these values, taken from this repo:goodmem-camelPAIR-Systems-Incgoodmem_camelpublish.ymlpypiThe GitHub environment
pypihas a single deployment policy,v*(type: tag), sov0.4.0is allowed to deploy.What failed before, and how it behaves now
Before (the published
camel-goodmem0.3.0 / origin/main):After (this branch):
pip install goodmem-camelwill resolve oncev0.4.0has been published.I also ran every workflow
run:block locally. Each was extracted from the YAML and passedbash -nbefore running.ci.yml/teston 3.10, 3.11, 3.12, 3.130.4.0ci.yml/floorson 3.100.4.0; 517 tests passedci.yml/gatespublish.yml/buildtwine checkpassedA key scan of the added lines found nothing.
Where the old names still appear
A search of every tracked file for
camel_goodmemandcamel-goodmem(case and separator variants) finds one line: the README Changes in 0.4.0 entry, "update imports fromcamel_goodmemtogoodmem_camel". It is history and is kept on purpose.🤖 Generated with Claude Code