Repository navigation
Rename to OwlBot and move to meshcore-go v1.7.0 - #26
Merged
Merged
Conversation
A test restoring probeInterval in its cleanup could race a probe goroutine that had not read it yet (about 1 run in 14 under -race). Read it in watch() and pass it in.
The meshcore-bot name is taken. The module, binary, release assets and Docker image are now OwlBot, and MQTT status reports model OwlBot and client_version OwlBot/<version>. Stored state is untouched: the config file and mqtt_identity.key keep their names, and mesh identities still come from bot names. meshcore-go v1.7.0 moved to github.com/OwlShack/meshcore-go. Adapt to Seed() and the sx12xx NoiseFloor() returning an ok flag, use hardware.PreambleForSF, and correct the KISS ordering comments now that the library matches each reply to its request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames meshcore-bot to OwlBot (the old name belongs to another tool) and moves to meshcore-go v1.7.0, which now lives at
github.com/OwlShack/meshcore-go.Rename
github.com/OwlShack/OwlBot. Binary, release assets (OwlBot-<os>-<arch>) and the Docker image binary areOwlBot; the image is published toghcr.io/${{ github.repository }}.modelisOwlBot,client_versionisOwlBot/<version>, the same pattern as OwlShack.meshcore-botalias in the image./data, somqtt_identity.keysurvives a new container.Upgrades do not lose state. The bot's only state is the config file (plus
.bak-*) andmqtt_identity.key, both in the working directory, and mesh identities derive from bot names; none is keyed on the program name. Checked by running the released v1.2.0 binary, then this build, in one folder against a local broker: the key file hash andorigin_id/topic were identical, and onlymodel/client_versionchanged. Users who mounted onlyconfig.tomlin Docker have their key inside the old container; the upgrade notes give thedocker cp.meshcore-go v1.7.0
LocalIdentity.Seed()returns(seed, ok): saving refuses an identity with no seed instead of writing an all-zero key.NoiseFloor()returns(dBm, ok): noise floor stays unset until measured.hardware.PreambleForSFreplaces the deprecated sx12xx one.Also
probeIntervalafter a test's cleanup restored it. About 1 run in 14 under-race; 0 in 60 after.Testing
go vet, build,go test -race(CI's commands).OwlBotfrom/data.GetBatteryetc.) are still used; moving to the typed calls is a later cleanup that wants a radio.Before the next release
The repo is now
OwlShack/meshcore-bot. Rename it to OwlBot before tagging, or the image is published asghcr.io/owlshack/meshcore-botrather thanghcr.io/owlshack/owlbotas the README says.