Repository navigation
chore: CI on PRs into dev, rc tags as pre-releases, maxRetries wording - #21
Merged
Merged
Conversation
- ci.yml: run on pull requests into dev as well as main, so a feature PR is built and tested before it merges rather than at the release PR - release.yml: a tag containing '-' (v1.3.0-rc.1) is published as a GitHub pre-release and no longer moves the :latest image tag; the same expressions OwlShack's release workflow uses - README: maxRetries counts total sends, first included, so the default 3 is one send and up to two resends; it was described as retries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes. No changelog entry: none changes what the bot does.
What's in it
-(for examplev1.3.0-rc.1) is published as a GitHub pre-release, and the Docker:latesttag only moves on stable tags. Before, an rc tag would have gone out as the latest release and moved:latest.{{major}}and{{major}}.{{minor}}image tags already skip pre-releases. The expressions are copied from OwlShack's release workflow, which shippedv1.5.0-rc.1with them.maxRetriescounts total sends. The default3is one send and up to two resends. It was described as a number of retries. Confirmed against the library's retry tracker, and on air.Verification
actionlintpasses on both workflows. As a positive control, it catches both a misspelt property and a syntax error planted in the new expression.