refactor(storage): make raw query policy reviewable - #2198
Conversation
d178509 to
e5a8502
Compare
|
@otReviewAgent Please review current rebased head e5a8502 for convergence. It is based on converged #2187, fixes the prefixed-name default-graph guard bypass, and passes the complete Query suite (339/339). |
|
Review Agent: please run a fresh merge-readiness review against current head |
|
@otReviewAgent Please review current head |
|
@otReviewAgent Please review the current head after the empty retrigger commit; the scanner-contract remediation remains unchanged and prior threads are resolved. |
6f059aa to
95f98de
Compare
|
@otReviewAgent Please review current integration-based head |
|
@otReviewAgent Please review current head |
|
@otReviewAgent Please review current head |
Summary
Request.query()exception out of production code and into an exact occurrence-counted architecture-gate record; untyped store aliases, updates, and unreviewed dynamic calls remain fail-closed.Related
Diagrams
Dynamic raw-query review
Before:
sequenceDiagram participant Source as First-party source participant Gate as Architecture gate participant Baseline as Package fingerprint Source->>Gate: Dynamic TripleStore.query expression Gate->>Baseline: Compare opaque package hash Baseline-->>Gate: Match or package-wide mismatchAfter:
sequenceDiagram participant Source as First-party source participant Gate as Architecture gate participant Baseline as Reviewed inventory Source->>Gate: Dynamic TripleStore.query expression Gate->>Gate: Reject raw updates and unreviewed exceptions Gate->>Baseline: Compare stable semantic record Baseline-->>Gate: Exact match or reviewable multiline diffSPARQL admission and traversal
Before:
sequenceDiagram participant Caller participant Core participant Query Caller->>Core: SPARQL admission Core->>Core: Core-owned word boundary heuristics Caller->>Query: Structural traversal Query->>Query: Query-owned prefix and token grammarAfter:
sequenceDiagram participant Caller participant Core participant Query Caller->>Core: SPARQL admission Core->>Core: Consume canonical Core lexer Caller->>Query: Structural traversal Query->>Core: Consume canonical Core lexerFiles changed
scripts/check-managed-store-raw-channels.mjsscripts/managed-store-dynamic-query-inventory.json.github/workflows/system-record-managed-ownership.ymlpackages/core/src/sparql-lexer.tspackages/core/src/sparql-operation.tspackages/query/src/sparql-utils.tspackages/query/src/dkg-query-engine.tspackages/query/src/sparql-graph-scope.tspackages/query/src/sparql-guard.tspackages/agent/src/generic-sql-source.tsTest plan
packages/core/test/sparql-operation.test.ts(3/3), including dotted-prefix and triple-separator boundaries.pnpm check:managed-store-raw-channels; all 287 records match, duplicate MSSQL exceptions are rejected, and failed scans cannot rewrite the baseline.git diff --check.