feat: answer duplicate prompts once instead of once per file - #204
Merged
Conversation
…time Ten files dropped onto ten that already exist raised ten identical questions, each needing its own click, with nothing saying how many were left. The dialog now offers to apply one answer to everything waiting, shows the count, and distinguishes skipping this file from cancelling the whole drop.
The first attempt gated its new controls on more than one prompt being queued, but prompts are raised one at a time: use-upload-dispatch awaits each answer before the next question exists, so the queue never holds two and none of it ever rendered. The answer is carried back to that loop instead, which honours it by not asking again. Cancel now resolves too, rather than leaving the loop waiting forever and stalling the whole drop.
General settings gains a "When a file already exists" choice of ask, keep both, or replace, defaulting to ask. A policy seeds the same standing answer the prompt's "do the same for the rest" sets, so a drop of ten collisions finishes without a prompt. Replacing unasked leaves a notice saying how many files were overwritten.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Rakesh-46-VR
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping 10 files onto 10 that already exist asked 10 identical questions, one per file, with nothing saying how many were left.
What's new
Bug found along the way
Cancel closed the dialog and resolved nothing, so the upload loop waited forever. Every file behind the cancelled one was never asked about and never uploaded, silently. Cancel is now a real answer: "Skip this one" skips one file, "Cancel all" abandons the rest.
How to check
Upload
a.txt,b.txt,c.txtto a folder first, so they exist.a (1).txt,b (1).txt,c (1).txt.Note: verified by tests and typecheck, not in a browser.