Do not swallow RunTimeoutError while collecting facts - #643
Open
silug wants to merge 1 commit into
Open
Conversation
`Puppet::Agent::RunTimeoutError` inherits from `Exception` so that it
escapes the usual `rescue StandardError` handlers and aborts the run. The
fact handler, however, rescues `Exception` and only re-raises SystemExit
and NoMemoryError, so a run timeout that fires during fact collection was
wrapped into a plain Puppet::Error ("Could not retrieve local facts:
execution expired") and the run carried on to send a report as if nothing
had happened.
Re-raise RunTimeoutError alongside SystemExit and NoMemoryError so the
agent aborts the run as intended.
Fixes part of OpenVoxProject#485
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
1 task
silug
marked this pull request as ready for review
September 4, 2026 15:57
silug
enabled auto-merge
September 4, 2026 15:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Puppet::Agent::RunTimeoutErrorinherits fromExceptionso that it escapes the usualrescue StandardErrorhandlers and aborts the run. The fact handler, however, rescuesExceptionand only re-raises SystemExit and NoMemoryError, so a run timeout that fires during fact collection was wrapped into a plain Puppet::Error ("Could not retrieve local facts: execution expired") and the run carried on to send a report as if nothing had happened.Re-raise RunTimeoutError alongside SystemExit and NoMemoryError so the agent aborts the run as intended.
Fixes part of #485
Generated by Claude Code
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent