Kill the forked agent run if it outlives runtimeout - #642
Open
silug wants to merge 1 commit into
Open
Conversation
The daemon forks a child for each catalog run and waited on it with a bare `Process.waitpid2`. The child enforces `runtimeout` on its own run, but nothing guaranteed that it would actually exit afterwards: a stranded thread or hung subprocess left the parent blocked forever and the agent stopped checking in until the service was restarted. Poll the child with `WNOHANG` and, once `runtimeout` plus a grace period for sending the report has elapsed, SIGKILL it and reap it so the daemon carries on with its schedule. A `runtimeout` of 0 keeps the old blocking behaviour. Fixes part of OpenVoxProject#485 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
1 task
silug
marked this pull request as ready for review
September 4, 2026 15:58
silug
enabled auto-merge
September 4, 2026 15:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
The daemon forks a child for each catalog run and waited on it with a bare
Process.waitpid2. The child enforcesruntimeouton its own run, but nothing guaranteed that it would actually exit afterwards: a stranded thread or hung subprocess left the parent blocked forever and the agent stopped checking in until the service was restarted.Poll the child with
WNOHANGand, onceruntimeoutplus a grace period for sending the report has elapsed, SIGKILL it and reap it so the daemon carries on with its schedule. Aruntimeoutof 0 keeps the old blocking behaviour.Fixes part of #485
Generated by Claude Code
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent