Skip to content

Remove legacy network HTTP APIs #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
silug wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Remove legacy network HTTP APIs #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f76945
Remove legacy network HTTP APIs
silug Feb 22, 2026
8e211ee
Workaround for Windows tests
silug Apr 13, 2026
f8b5a5d
Fix Windows timestamp race in generate_spec
silug Apr 13, 2026
18523e2
Additional attempt to fix Windows tests
silug Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/puppet/generate/type.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ def format=(format)
# @return [Boolean] Returns true if the output is up-to-date or false if not.
def up_to_date?(outputdir)
f = effective_output_path(outputdir)
Puppet::FileSystem.exist?(f) && (Puppet::FileSystem.stat(@path) <=> Puppet::FileSystem.stat(f)) <= 0
Puppet::FileSystem.exist?(f) &&
Puppet::FileSystem.stat(@path).mtime <= Puppet::FileSystem.stat(f).mtime
end

# Gets the filename of the output file.
Expand Down
7 changes: 0 additions & 7 deletions lib/puppet/http.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,4 @@ module HTTP
require_relative 'http/retry_after_handler'
require_relative 'http/external_client'
end

# Legacy HTTP API
module Network
module HTTP
require_relative '../puppet/network/http_pool'
end
end
end
288 changes: 0 additions & 288 deletions lib/puppet/network/http/connection.rb
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions lib/puppet/network/http/handler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,6 @@ def headers(request)
raise NotImplementedError
end

# The mime type is always passed to the `set_content_type` method, so
# it is no longer necessary to retrieve the Format's mime type.
#
# @deprecated
def format_to_mime(format)
format.is_a?(Puppet::Network::Format) ? format.mime : format
end

# Create a generic puppet request from the implementation-specific request
# created by the web server
def make_generic_request(request)
Expand Down
Loading