Skip to content

Survive the openvox repo's broken nested tags when picking a release #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miharp wants to merge 1 commit into from
Closed

Survive the openvox repo's broken nested tags when picking a release #473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions lib/puppet_references/repo.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,20 @@ def tags
end

def newest_release
@repo.tags.map { |t| Gem::Version.new(t.name) rescue Gem::Version.new(0) } # rubocop:disable Style/RescueModifier
.reject(&:prerelease?)
.max.version # rubocop:disable Layout/MultilineMethodCallIndentation
versions = tag_names.filter_map { |name| Gem::Version.new(name) rescue nil } # rubocop:disable Style/RescueModifier
.reject(&:prerelease?)
raise "#{@name}: no stable release tag found" if versions.empty?

versions.max.version
end

# Tag names straight from `git tag --list`. The git gem's tag enumeration
# (Git::Base#tags) re-resolves every name and, since git 5.x, raises on the
# literal `tags/2.6.0rc*` tags that exist in the openvox repository, so
# list the names without validating them; non-version names are discarded
# by the caller anyway.
def tag_names
Dir.chdir(@directory) { `git tag --list`.split("\n") }
end

def update_bundle
Expand Down