Skip to content

Inspector: fixes media reference crashes #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timlehr merged 2 commits into from
Sep 11, 2026
Merged

Inspector: fixes media reference crashes #167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c465205
Inspector: fixes media reference crashes
timlehr Sep 9, 2026
af3c6ea
Merge branch 'main' into tlehr/mediaRefInspectorFix
timlehr Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions inspector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,13 +773,10 @@ void DrawInspector() {

// Array of names and corresponding MediaReference pointers
std::vector<const char*> reference_names;
otio::MediaReference** reference_objects = new otio::MediaReference*[media_references.size()];

size_t i = 0;
std::vector<otio::MediaReference*> reference_objects;
for (const auto& media_reference : media_references) {
reference_names.push_back(media_reference.first.c_str());
reference_objects[i] = media_reference.second;
i++;
reference_objects.push_back(media_reference.second);
}
int num_references = static_cast<int>(media_references.size());

Expand All @@ -796,7 +793,7 @@ void DrawInspector() {
}

// Set the active media ref key based on user selection
if (ImGui::Combo("##", &appState.selected_reference_index, reference_names.data(), num_references)) {
if (ImGui::Combo("##media_reference", &appState.selected_reference_index, reference_names.data(), num_references)) {
if (appState.selected_reference_index >= 0 && appState.selected_reference_index < num_references) {
clip->set_active_media_reference_key(reference_names[appState.selected_reference_index]);
}
Expand Down
Loading