Chore/update nugets - #2294
Merged
Merged
Conversation
Upgraded ModelContextProtocol and NSubstitute packages in Directory.Packages.props. Suppressed IDE0041 and IDE0008 warnings in Directory.Build.props. Refactored NSubstitute .Returns usage in test files to enforce explicit type checking for AddChannel arguments, throwing InvalidOperationException on type mismatch.
maximilien-noal
added
the
3rd party
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
It introduces global suppression of IDE style warnings (IDE0041/IDE0008) in build props, which disables existing codebase conventions rather than addressing or reconfiguring them.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR updates third-party NuGet dependencies and bumps the project/package version to v16.1.0 to support a new release of the Spice86 NuGet packages.
Changes:
- Updated centrally managed package versions (notably Avalonia, NSubstitute, ModelContextProtocol, SkiaSharp, and test SDK dependencies).
- Updated DOS/CD-ROM related tests to use safer argument extraction in NSubstitute
Returnsdelegates. - Bumped package/version metadata to
16.1.0.
File summaries
| File | Description |
|---|---|
| tests/Spice86.Tests/Dos/DosProcessManagerTests.cs | Adjusted NSubstitute Returns to validate CallInfo argument types before constructing SoundChannel. |
| tests/Spice86.Tests/Dos/CdRomTestFixture.cs | Same as above, plus keeps capturing the created channel and callback. |
| tests/Spice86.Tests/Dos/CdRomParityTests.cs | Same as above for CD-ROM parity test setup. |
| tests/Directory.Packages.props | Updated test package versions (Microsoft.NET.Test.Sdk, NSubstitute, Avalonia.Headless). |
| src/Directory.Packages.props | Updated application package versions (Avalonia stack, Dock, MCP, NSubstitute, SkiaSharp, etc.). |
| src/Directory.Build.props | Bumped version to 16.1.0 and added IDE warning suppressions to NoWarn. |
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| <WarningsAsErrors>nullable</WarningsAsErrors> | ||
| <NoWarn>$(NoWarn);1591;NU1507</NoWarn> | ||
| <NoWarn>$(NoWarn);1591;NU1507;IDE0041;IDE0008</NoWarn> |
kevinferrare
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Updates third party packages. Makes the version bump to v16.1.
Rationale behind Changes
Release a new version of the Nuget packages.
Suggested Testing Steps