Gravity v4 - Draft#1235
Open
ehariton wants to merge 11 commits into
Open
Conversation
…l errors in test values that appeared in test_flight_path_ode.py due to the use of altitude_rate.py and its english 32.2ft/s**2 to metric 9.81m/s**2 conversion that is now enforced by openmdao to be a conversion from 32.2ft/s**2 to 9.81456m/s**2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All gravity constants are now uniform and encapsulated in constants.py . The differences between FLOPS and GASP gravities have been eliminated.
Follow on to #1219, #1227, #1232.
Removes GRAV_ENGLISH_GASP and replaces with Mission.GRAVITY.
One reference to GNS as gravity in a standard python function was replaced with constants.GRAV_EARTH.
Related Issues
Partially resolves #1192
Backwards incompatibilities
None
AI Usage
None.