Skip to content

refactor: remove mocking module and associated feature flag - #249

Merged
Ghoul4500 merged 1 commit into
OpenGamingCollective:mainfrom
scardracs:cleanup/remove-dead-mocking-code
Aug 1, 2026
Merged

refactor: remove mocking module and associated feature flag#249
Ghoul4500 merged 1 commit into
OpenGamingCollective:mainfrom
scardracs:cleanup/remove-dead-mocking-code

Conversation

@scardracs

@scardracs scardracs commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2271eccb-b9c7-42a0-9482-73de0f7b0650

📥 Commits

Reviewing files that changed from the base of the PR and between e36a23f and a1ed13b.

📒 Files selected for processing (3)
  • rog-control-center/Cargo.toml
  • rog-control-center/src/lib.rs
  • rog-control-center/src/mocking.rs
💤 Files with no reviewable changes (3)
  • rog-control-center/Cargo.toml
  • rog-control-center/src/mocking.rs
  • rog-control-center/src/lib.rs

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Removed the obsolete mocking feature and associated mock control interfaces.
    • Mock implementations for power, BIOS settings, platform profiles, charging, LEDs, Anime controls, and supported-function queries are no longer available.

Walkthrough

The change removes the mocking Cargo feature, its public module export, and the associated mock implementations from rog-control-center.

Changes

rog-control-center mocking removal

Layer / File(s) Summary
Remove mocking feature and exports
rog-control-center/Cargo.toml, rog-control-center/src/lib.rs, rog-control-center/src/mocking.rs
The package no longer declares the mocking feature or exports the feature-gated mocking module. The mocking implementations and public mock APIs are deleted.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: rog-control-center

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes removal of the mocking module and its associated feature flag.
Description check ✅ Passed The description explains the changes, rationale, and verification results, but it omits the issue reference and tested hardware and environment details.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@scardracs

Copy link
Copy Markdown
Contributor Author

Ghoul in the end it was dead code so I decided to remove it completely

@coderabbitai coderabbitai Bot added the rog-control-center ROG Control Center GUI label Jul 31, 2026

@Ghoul4500 Ghoul4500 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this does indeed seem to be dead code. But I wonder what luke was trying to do when he originally added this. I think it became obsolete later but some parts may be salvageable and/or usable. I'm marking this approved for me to merge later but in the meantime you can try to find what this was originally used for, and if it really has no business being here, I will merge this commit tonight

@scardracs

scardracs commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Hmm, this does indeed seem to be dead code. But I wonder what luke was trying to do when he originally added this. I think it became obsolete later but some parts may be salvageable and/or usable. I'm marking this approved for me to merge later but in the meantime you can try to find what this was originally used for, and if it really has no business being here, I will merge this commit tonight

I already took a look at it: it was thought as a mock to be able to start asusctl on non-asus laptop to program/test out things. Honestly, I don't think someone would run asusctl on a non-asus laptop nowadays, also because most of the things are not working as was thought back in the days

@Ghoul4500

Copy link
Copy Markdown
Member

I already took a look at it: it was thought as a mock to be able to start asusctl on non-asus laptop to program/test out things. Honestly, I don't think someone would run asusctl on a non-asus laptop nowadays, also because most of the things are not working as was thought back in the days

Looks like that is what it was made for. LGTM then

@Ghoul4500
Ghoul4500 merged commit e4e647d into OpenGamingCollective:main Aug 1, 2026
1 check passed
@scardracs
scardracs deleted the cleanup/remove-dead-mocking-code branch August 1, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rog-control-center ROG Control Center GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants