refactor: remove mocking module and associated feature flag - #249
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change removes the Changesrog-control-center mocking removal
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
|
Ghoul in the end it was dead code so I decided to remove it completely |
Ghoul4500
left a comment
There was a problem hiding this comment.
Hmm, this does indeed seem to be dead code. But I wonder what luke was trying to do when he originally added this. I think it became obsolete later but some parts may be salvageable and/or usable. I'm marking this approved for me to merge later but in the meantime you can try to find what this was originally used for, and if it really has no business being here, I will merge this commit tonight
I already took a look at it: it was thought as a mock to be able to start asusctl on non-asus laptop to program/test out things. Honestly, I don't think someone would run asusctl on a non-asus laptop nowadays, also because most of the things are not working as was thought back in the days |
Looks like that is what it was made for. LGTM then |
No description provided.