Skip to content

feat: Add FA401WU supports - #155

Open
scardracs wants to merge 1 commit into
OpenGamingCollective:mainfrom
scardracs:FA401WU
Open

feat: Add FA401WU supports#155
scardracs wants to merge 1 commit into
OpenGamingCollective:mainfrom
scardracs:FA401WU

Conversation

@scardracs

Copy link
Copy Markdown
Contributor

Closes: #151
Signed-off-by: Marco Scardovi scardracs@disroot.org

@miche-egg564

miche-egg564 commented Jul 9, 2026

Copy link
Copy Markdown

i tried using this early using the help of claude to manually install it and here is what claude said after finishing "aura_support.ron fix landed and asusd now matches FA401WU correctly, but keyboard still doesn't light up — kbd_rgb_state file still missing at the kernel level." Maybe this can be helpful thank you so much for helping me so far

@scardracs

Copy link
Copy Markdown
Contributor Author

i tried using this early using the help of claude to manually install it and here is what claude said after finishing "aura_support.ron fix landed and asusd now matches FA401WU correctly, but keyboard still doesn't light up — kbd_rgb_state file still missing at the kernel level." Maybe this can be helpful thank you so much for helping me so far

That's because https://lore.kernel.org/platform-driver-x86/20260621090230.41249-2-scardracs@disroot.org/ has been merged into ilpo's repo only and not into main kernel. You have to wait for about another week or two to see it into the kernel

@scardracs
scardracs force-pushed the FA401WU branch 2 times, most recently from 2f8cb66 to a52ff66 Compare July 12, 2026 18:30
@Ghoul4500

Copy link
Copy Markdown
Member

i tried using this early using the help of claude to manually install it and here is what claude said after finishing "aura_support.ron fix landed and asusd now matches FA401WU correctly, but keyboard still doesn't light up — kbd_rgb_state file still missing at the kernel level." Maybe this can be helpful thank you so much for helping me so far

That's because https://lore.kernel.org/platform-driver-x86/20260621090230.41249-2-scardracs@disroot.org/ has been merged into ilpo's repo only and not into main kernel. You have to wait for about another week or two to see it into the kernel

You have tested this with the patch on this model? also pls reword the commit with Feat: {message} while ur at it. Thanks

@scardracs scardracs changed the title Add FA401WU supports Feat: Add FA401WU supports Jul 12, 2026
@scardracs

Copy link
Copy Markdown
Contributor Author

i tried using this early using the help of claude to manually install it and here is what claude said after finishing "aura_support.ron fix landed and asusd now matches FA401WU correctly, but keyboard still doesn't light up — kbd_rgb_state file still missing at the kernel level." Maybe this can be helpful thank you so much for helping me so far

That's because https://lore.kernel.org/platform-driver-x86/20260621090230.41249-2-scardracs@disroot.org/ has been merged into ilpo's repo only and not into main kernel. You have to wait for about another week or two to see it into the kernel

You have tested this with the patch on this model? also pls reword the commit with Feat: {message} while ur at it. Thanks

Done. I need @miche-egg564 to test both this patch and lore to be sure it works as expected 'cause I don't have this model

@miche-egg564

Copy link
Copy Markdown

Tested the latest push on real FA401WU hardware. aura_support.ron fix confirmed working — logs show Matched to FA401WU correctly. Keyboard backlight still doesn't turn on, as expected, since kbd_rgb_state isn't in my running kernel yet (matches what you said re: the lore.kernel.org patch only being in ilpo's tree so far). Will retest once that kernel patch lands in mainline / gets into Fedora's kernel.

@Ghoul4500

Copy link
Copy Markdown
Member

I'm more concerned here about the fact that the layout_name in the ron file is untested (can't be without the kernel patch). In my experience having the wrong layout_name sometimes does weird things. I looked up images of these 2 models and it seems the FA506 is an A15 with a numpad whhile this target model is an A14 without a numpad. I'm quite certain that is not the right layout_name. I think ga401q may be more appropriate, but I want this to be tested on a working kernel

@scardracs
scardracs force-pushed the FA401WU branch 2 times, most recently from 3d13d05 to e7cbe36 Compare July 13, 2026 19:18
@scardracs scardracs changed the title Feat: Add FA401WU supports feat: Add FA401WU supports Jul 14, 2026
@miche-egg564

Copy link
Copy Markdown

is there anyway i can test it without building a kernelt because that is not something i am capable of

maybe send an image of my keyboards layout or anything else (sorry i take so long to respond)

@scardracs
scardracs force-pushed the FA401WU branch 2 times, most recently from 928675d to e628895 Compare July 18, 2026 16:46
@scardracs

Copy link
Copy Markdown
Contributor Author

The only way is for you to compile the kernel or wait for my commit to be merged into a RC kernel release (probably it will go to kernel 7.3 so you'll have to wait at least another month or 2)

@miche-egg564

Copy link
Copy Markdown

ok ill wait i supose

@scardracs
scardracs marked this pull request as draft July 23, 2026 18:29
@scardracs
scardracs force-pushed the FA401WU branch 4 times, most recently from 33da2f6 to d6fe585 Compare July 27, 2026 12:34
@scardracs

scardracs commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Ok so my commit has been merged into linux-next. At this point I hope it will be merged inside one of kernel 7.2 rcs https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/platform/x86/asus-armoury.h?h=next-20260726&id=c036e9e5643d2b09eee51cdd8d1605f7b41d7b10

@scardracs
scardracs marked this pull request as ready for review July 29, 2026 18:47
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@scardracs, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 37539299-1404-459c-8522-2c58af654675

📥 Commits

Reviewing files that changed from the base of the PR and between 4d8a45b and 4a30148.

📒 Files selected for processing (1)
  • rog-aura/data/aura_support.ron

Comment @coderabbitai help to get the list of available commands.

Closes: OpenGamingCollective#151
Signed-off-by: Marco Scardovi <scardracs@disroot.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard backlight non-functional on ASUS TUF Gaming A14 FA401WU

3 participants