feat: Add FA401WU supports - #155
Conversation
|
i tried using this early using the help of claude to manually install it and here is what claude said after finishing "aura_support.ron fix landed and asusd now matches FA401WU correctly, but keyboard still doesn't light up — kbd_rgb_state file still missing at the kernel level." Maybe this can be helpful thank you so much for helping me so far |
That's because https://lore.kernel.org/platform-driver-x86/20260621090230.41249-2-scardracs@disroot.org/ has been merged into ilpo's repo only and not into main kernel. You have to wait for about another week or two to see it into the kernel |
2f8cb66 to
a52ff66
Compare
You have tested this with the patch on this model? also pls reword the commit with |
Done. I need @miche-egg564 to test both this patch and lore to be sure it works as expected 'cause I don't have this model |
|
Tested the latest push on real FA401WU hardware. aura_support.ron fix confirmed working — logs show Matched to FA401WU correctly. Keyboard backlight still doesn't turn on, as expected, since kbd_rgb_state isn't in my running kernel yet (matches what you said re: the lore.kernel.org patch only being in ilpo's tree so far). Will retest once that kernel patch lands in mainline / gets into Fedora's kernel. |
|
I'm more concerned here about the fact that the layout_name in the ron file is untested (can't be without the kernel patch). In my experience having the wrong layout_name sometimes does weird things. I looked up images of these 2 models and it seems the FA506 is an A15 with a numpad whhile this target model is an A14 without a numpad. I'm quite certain that is not the right layout_name. I think ga401q may be more appropriate, but I want this to be tested on a working kernel |
3d13d05 to
e7cbe36
Compare
|
is there anyway i can test it without building a kernelt because that is not something i am capable of maybe send an image of my keyboards layout or anything else (sorry i take so long to respond) |
928675d to
e628895
Compare
|
The only way is for you to compile the kernel or wait for my commit to be merged into a RC kernel release (probably it will go to kernel 7.3 so you'll have to wait at least another month or 2) |
|
ok ill wait i supose |
33da2f6 to
d6fe585
Compare
|
Ok so my commit has been merged into linux-next. At this point I hope it will be merged inside one of kernel 7.2 rcs https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/platform/x86/asus-armoury.h?h=next-20260726&id=c036e9e5643d2b09eee51cdd8d1605f7b41d7b10 |
|
Warning Review limit reached
Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
Closes: OpenGamingCollective#151 Signed-off-by: Marco Scardovi <scardracs@disroot.org>
Closes: #151
Signed-off-by: Marco Scardovi scardracs@disroot.org