Skip to content

Fix world.GetConfig() parity #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ike709 wants to merge 2 commits into from
Closed

Fix world.GetConfig() parity #2552

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5582a5c
Fix `world.GetConfig()` parity
Apr 5, 2026
0576aba
resharper
Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Content.Tests/DMProject/Tests/Builtins/world_config.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@

world.SetConfig("env", env_var, env_value)
world.SetConfig("env", env_var, 17)
ASSERT(world.GetConfig("env", env_var) == null)
ASSERT(world.GetConfig("env", env_var) == "")
8 changes: 5 additions & 3 deletions OpenDreamRuntime/Procs/Native/DreamProcNativeWorld.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,13 @@
// DM ref says: "If no parameter is specified, a list of the names of all available parameters is returned."
// but apparently it's actually just null for "env".
return DreamValue.Null;
} else if (param.TryGetValueAsString(out var paramString) && Environment.GetEnvironmentVariable(paramString) is string strValue) {
}

if (param.TryGetValueAsString(out var paramString) && Environment.GetEnvironmentVariable(paramString) is string strValue) {
Comment thread Fixed
return new DreamValue(strValue);
} else {
return DreamValue.Null;
}

return DreamValue.EmptyString;
case "ban":
case "keyban":
case "ipban":
Expand Down
Loading