fv_read_section_efiapi: adjust data pointer - #1747
Open
olegilyasov wants to merge 1 commit into
Open
Conversation
Contributor
⌛ QEMU Validation PendingQEMU validation is pending on successful CI completion.
This comment was automatically generated by the Patina QEMU PR Validation workflow. |
1 task
Contributor
|
I accidentally clicked the copilot review button and now I'm not sure how to get it to stop, my apologies. |
- when FV section type EFI_SECTION_FREEFORM_SUBTYPE_GUID then the section content includes: 1) Section Header (4 Bytes) 2) Subtype GUID (16 Bytes) 3) Data payload (N Bytes) - read section function currently returns data pointer as section_start + sizeof(section_header) + sizeof(guid) - the correct data pointer would be section_start + sizeof(section_header) Signed-off-by: Oleg Ilyasov <olegi@ami.com>
olegilyasov
force-pushed
the
olegilyasov/fv_ReadSection_ptrmiss
branch
from
August 16, 2026 02:48
377b8b0 to
fe73b13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The fix changes fv_read_section_efiapi so FREEFORM_SUBTYPE_GUID returns the subtype GUID header bytes followed by the payload, instead of returning only the payload.
How This Was Tested
Added test_fv_read_section_freeform_subtype_returns_guid_plus_payload
Integration Instructions
N/A