Skip to content

Improve labor tracking layout and dark mode - #5510

Open
mahathiganimi wants to merge 1 commit into
developmentfrom
Mahathi_fix_labor_time_tracking_layout_darkmode
Open

Improve labor tracking layout and dark mode#5510
mahathiganimi wants to merge 1 commit into
developmentfrom
Mahathi_fix_labor_time_tracking_layout_darkmode

Conversation

@mahathiganimi

Copy link
Copy Markdown

Description

This PR improves the Distribution of Labor Hours visualization on the Labor and Time Tracking dashboard, including filter functionality, layout alignment, chart readability, and Dark Mode styling.
Screenshot 2026-09-05 at 4 51 55 PM
Screenshot 2026-09-05 at 4 52 32 PM

Related PRS (if any):

Related PR https://github.com/OneCommunityGlobal/HighestGoodNetworkApp/pull/4105

Main changes explained:

  1. Improved the Pie Chart visualization for labor-hour distribution.
  2. Aligned the From, To, Project, Member, and Submit filter controls.
  3. Fixed Project and Member dropdown interaction and menu visibility.
  4. Added functional date, project, and member filtering through the Submit button.
  5. Improved pie-chart percentage and tooltip readability.
  6. Added Dark Mode styling for date inputs, dropdowns, labels, and tooltip text.
  7. Added no-data handling and filter-applied feedback.

How to test:

  1. Check out the current PR branch.
  2. Run npm install and npm run start:local to start the application locally.
  3. Clear site data/cache if necessary.
  4. Log in as an Admin user.
  5. Go to http://localhost:5173/bmdashboard/totalconstructionsummary.
  6. Verify with mock data:
    a. Pie chart, percentage labels, legend, and tooltips display correctly.
    b. From, To, Project, Member, and Submit controls are properly aligned.
    c. Project and Member dropdowns remain open and options can be selected normally.
    d. Clicking Submit applies the selected filters and updates the visualization.
    e. Dark Mode displays readable date inputs, dropdowns, pie-chart percentages, and tooltip text.
    f. Layout and visualization remain readable when resizing the page.

@netlify

netlify Bot commented Sep 5, 2026

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 6e81f18
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a9c819e420c5b000857f028
😎 Deploy Preview https://deploy-preview-5510--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2026

Copy link
Copy Markdown

@iAbhi001
iAbhi001 self-requested a review September 5, 2026 23:58

@iAbhi001 iAbhi001 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this PR, @mahathiganimi! I tested this branch locally on http://localhost:5173/bmdashboard/totalconstructionsummary.

Overall, the primary updates to the Distribution of Labor Hours card look solid, but there are a few visual alignment issues and potential layout regressions on adjacent components that need attention before merging:


1. Distribution of Labor Hours (Target Component)

  • Submit Button Alignment: The Submit button is currently left-aligned directly underneath the From and To inputs. It would look much cleaner centered across the entire filter row or placed inline to the right of the dropdowns.
  • Legend & Pie Layout: The legend items on the left sit quite high up near the filters, leaving empty vertical space below. Centering the legend vertically against the pie chart would balance the card nicely.
  • Dark Mode Contrast: The darkest pie slice (e.g., ~11.8%) blends heavily into the navy/slate background. Bumping up the lightness/contrast of that palette slice will improve visibility.

2. Regression Check: Adjacent Components

  • Paid Labor Cost Card: The adjacent card layout appears disrupted:

  • The Date Range label and input fields are floating directly over the middle of the chart canvas.

  • The chart's bottom legend items (Deployment (Actual), Deployment (Budget), etc.) are squished together and overlapping.

  • Please check if any global grid, flex, or container CSS classes were modified that unintentionally affected this neighboring component.

  • Issues Breakdown by Type Card: When hovering over Project D, a full white highlight/bar appears despite all issue counts showing 0. Please verify if this is expected hover behavior.


3. Weekly Project Summary Dashboard Polish (If in scope)

  • Date Badge Text Clipping: The date chips in the top-right header (Aug 23, 26 - Aug 29; and Aug 16, 26 - Aug 22r) have their dates truncated.
  • Accordion Title Typography: The chevrons appear as a raw lowercase letter v concatenated directly to the header strings without spacing (e.g., Risk profile for projectsv, Project Statusv, Issues Breakdownv).

Summary: The core pie chart visualization and filter updates are working well, but please review the layout scoping to ensure neighboring dashboard cards aren't broken by global styles. Happy to re-test once these adjustments are made!

Image Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants