Skip to content

Linlin - fix(profile): resolve dark mode background gaps and visual artifacts #5500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linlin-husky wants to merge 4 commits into
base: development
Choose a base branch
from
Open

Linlin - fix(profile): resolve dark mode background gaps and visual artifacts #5500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef724fc
fix(profile): resolve dark mode background gaps and visual artifacts
linlin-husky Sep 3, 2026
ad32d66
fix(profile): fix dark mode toggle switch visibility and contrast
linlin-husky Sep 3, 2026
50759e4
refactor: remove unused InlinePRSummary component to resolve duplication
linlin-husky Sep 3, 2026
f767c45
fix(profile): format code with Prettier and add clear English comment…
linlin-husky Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/components/UserProfile/BasicInformationTab/BasicInformationTab.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,21 +1025,26 @@ const BasicInformationTab = props => {
{videoCallPreferenceComponent}
<Col md="1" lg="1"></Col>
</Row>
<Row style={{ marginBottom: '10px' }}>
<Row>
{roleComponent}
<Col md="1" lg="1"></Col>
</Row>
<Row style={{ marginBottom: '10px' }}>
{/* Removed inline margins to align with standard CSS spacing and prevent dark mode layout gaps */}
<Row>
{locationComponent}
<Col md="1"></Col>
</Row>
<Row style={{ marginTop: '15px', marginBottom: '10px' }}>
{/* Removed inline margins to align with standard CSS spacing and prevent dark mode layout gaps */}
<Row>
{timeZoneComponent}
<Col md="1"></Col>
</Row>
<Row style={{ marginBottom: '10px' }}>{timeZoneDifferenceComponent}<Col md="1"></Col></Row>
<Row style={{ marginBottom: '10px' }}>{statusComponent}<Col md="1"></Col></Row>
<Row style={{ marginBottom: '10px' }}>{endDateComponent}<Col md="1"></Col></Row>
{/* Removed inline margins to align with standard CSS spacing and prevent dark mode layout gaps */}
<Row>{timeZoneDifferenceComponent}<Col md="1"></Col></Row>
{/* Removed inline margins to align with standard CSS spacing and prevent dark mode layout gaps */}
<Row>{statusComponent}<Col md="1"></Col></Row>
{/* Removed inline margins to align with standard CSS spacing and prevent dark mode layout gaps */}
<Row>{endDateComponent}<Col md="1"></Col></Row>
</>
) : (
<>
Expand Down
81 changes: 59 additions & 22 deletions src/components/UserProfile/BasicInformationTab/BasicInformationTab.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
/* stylelint-disable */
/* 1. Normalize background color for main content wrapper in dark mode */
:global(body.dark-mode) :global(#myTabContent) {
background-color: #1c2541 !important;
}

.basic-info-tab-tablet {
display: none;
}
}

.phone-input-style.phone-input-style {
width: 100%;
Expand All @@ -25,11 +29,6 @@
margin-right: 0 !important;
}






@media (width <= 1024px) {
.basic-info-tab-desktop {
display: none;
Expand All @@ -47,63 +46,89 @@
label {
font-weight: bold;
}


}

.basic-info-tab-desktop {
width: 100%;
}

/* 2. Set consistent dark mode background for desktop info container */
.basic-info-tab-desktop.dark-mode {
background-color: #1c2541;
}

.basic-info-tab-desktop:not(.dark-mode) :global(.form-control){
background-color: transparent;
}

.dark-mode {
/* marker class */
}

.dark-mode :global(.row) {
background-color: #1c2541 !important;
background-color: #1c2541;
margin-bottom: 8px;
margin-top: 0;
padding-bottom: 4px;
padding-top: 4px;
padding-left: 8px;
border: none;
border-bottom: none;
}

.dark-label-col {
background-color: #1c2541 !important;
background-color: #1c2541;
}

.dark-label-col:hover {
background-color: #1c2541 !important;
background-color: #1c2541;
}

/* 3. Normalize dark label container backgrounds in dark mode */
:global(.bg-yinmn-blue) .dark-label-col {
background-color: #1c2541 !important;
background-color: #1c2541;
}

.darkModeText {
color: white;
}

/* 4. Fix profile desktop functions background and layout in dark mode */
.dark-mode :global(.profile-functions-desktop) {
background-color: #1c2541;
border: none;
box-shadow: none;
padding-bottom: 16px;
}

/* 5. Override container and profile wrapper backgrounds to remove right-edge gaps in dark mode */
.dark-mode :global(.container),
.dark-mode :global(#containerProfile) {
background-color: #1c2541;
}

/* 6. Ensure active tab pane background consistency in dark mode */
.dark-mode :global(.tab-pane.active) {
background-color: #1c2541;
padding-bottom: 20px;
}

.darkMode.roleModal.button {
border-color: #2563eb !important;
background-color: #2563eb !important;
border-color: #2563eb;
background-color: #2563eb;
}

.darkMode.roleModal.button:hover {
color: #fff;
background-color: #1d4ed8 !important;
border-color: #1d4ed8 !important;
background-color: #1d4ed8;
border-color: #1d4ed8;
}

.roleModal.button {
color: #007bff;
background-color: #f8f9fa;

Check warning on line 125 in src/components/UserProfile/BasicInformationTab/BasicInformationTab.module.css

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Text does not meet the minimal contrast requirement with its background. 


See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HighestGoodNetworkApp&issues=AaBnZgaRfCScYMkUJcJ9&open=AaBnZgaRfCScYMkUJcJ9&pullRequest=5500
border-color: #007bff;
}

.roleModal.button:hover {
color: #fff;
background-color: #007bff;

Check warning on line 131 in src/components/UserProfile/BasicInformationTab/BasicInformationTab.module.css

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Text does not meet the minimal contrast requirement with its background. 


See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HighestGoodNetworkApp&issues=AaBnZgaRfCScYMkUJcJ-&open=AaBnZgaRfCScYMkUJcJ-&pullRequest=5500
border-color: #007bff;
}

Expand All @@ -111,4 +136,16 @@
color: #007bff;
border-color: #007bff;
background-color: transparent;
}
}

.dark-mode :global([class*="toggleDark"]),
:global(body.dark-mode) :global([class*="toggleDark"]) {
background-color: #475569 !important;
border: 1px solid #94a3b8 !important;
}

.dark-mode :global([class*="toggleDark"]):checked,
:global(body.dark-mode) :global([class*="toggleDark"]):checked {
background-color: #3b82f6 !important;
border-color: #3b82f6 !important;
}
Loading