Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ function TopCommunityMembers() {
</a>
)}
</td>
<td>
<td className={styles.scoreCell}>
<span className={scoreVal < 5 ? styles.lowScore : styles.highScore}>
{scoreVal}
</span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,16 +119,28 @@
/* ============================================
SCORE & PRIVATE HELPERS
============================================ */
.scoreCell {
white-space: nowrap;
}

.lowScore {
color: #e53e3e;
color: #c53030;
font-weight: 700;
}

.highScore {
color: #38a169;
color: #2f855a;
font-weight: 700;
}

.darkMode .lowScore {
color: #fc8181;
}

.darkMode .highScore {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new dark-mode highScore color is not taking effect at runtime.

I reproduced this locally on the current PR head at /topcommunitymembers. All of the available scores are 10/10, so they meet the >= 5 condition and should render green but they are still displayed in white in dark mode.

It looks like the global dark-mode rule in public/index.css (body.dark-mode * { color: #ffffff !important; }) is overriding this selector.

Could we make this override strong enough to take precedence so the Skill Score column actually uses the intended green color in dark mode?

Image

color: #68d391;
}

.private {
color: #a0aec0;
cursor: help;
Expand Down
Loading