Som Ramnani - fix(reset-timer-button): fix poor layout of the pop up window - #5488
Open
somramnani wants to merge 1 commit into
Open
Som Ramnani - fix(reset-timer-button): fix poor layout of the pop up window#5488somramnani wants to merge 1 commit into
somramnani wants to merge 1 commit into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
iAbhi001
self-requested a review
September 6, 2026 05:32
iAbhi001
approved these changes
Sep 6, 2026
iAbhi001
left a comment
There was a problem hiding this comment.
Hi @somramnani,
I tested this PR locally on branch som_fix/reset-timer-pop-up-layout and everything is working as expected:
- Unit Tests: Ran
TimerResetModal.test.jsxlocally and all tests passed. - Light Mode: Reset confirmation dialog opens centered, default styling is preserved, and buttons/text are clearly visible.
- Dark Mode: Verified the modal uses the new charcoal theme (
#343a40) across header, body, and footer—the previous blue background issue is resolved, with good contrast on text and the close button. - Functionality: Confirmed clicking "Yes, reset time!" successfully resets the timer without console errors.
LGTM! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Related PRS (if any):
This PR is related to the development backend
Main changes explained:
Timer.jsxto replace the Reset Time dialog’s dark-mode blue utility classes with a scoped reset-dialog theme, while preserving its light-mode appearance and reset behavior.Timer.module.cssto add a charcoal (#343a40) theme for the Reset Time dialog’s header, body, footer, borders, text, and close button.TimerResetModal.test.jsxto verify that the reset dialog opens correctly, uses the charcoal dark-mode theme without the blue background, remains default in light mode, and sends the reset action successfully.How to test:
som-feat/scroll-to-top-buttonnpm installand start the app locally.Screenshots or videos of changes:
Light Mode:
Dark Mode:
Demo:
https://github.com/user-attachments/assets/6faac91b-f08a-4f77-a7b9-129057b80c60
Note: