Akshay Fix Task Completed chart date filtering - #2321
Open
akv-iu wants to merge 1 commit into
Open
Conversation
|
akv-iu
marked this pull request as ready for review
August 27, 2026 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes bug list priority medium: the Total Org Summary "Task Completed" chart showed all-time Assigned and Completed totals when no comparison range was selected, so changing the date range did not change the chart.
Related PRs (if any):
N/A. This is a backend-only fix and does not require a frontend PR.
Main changes explained:
overviewReportHelper.jsso the non-comparison task aggregation uses the selected start and end dates.overviewReportHelper.spec.jswith a regression test that verifies the date-range match is applied.How to test:
Akshay_fix_task_completed_date_filter.npm install, then start the backend withnpm start.npx jest src/helpers/overviewReportHelper.spec.js --runInBand --noStackTrace.Screenshots or videos of changes:
Dev1.mp4
Note:
Root cause:
getTasksStatsappliedmodifiedDatetimeboundaries only when comparison dates were present. With "No Comparison" selected, it grouped every task in the database.Prettier passes for both modified files. ESLint reports zero errors and 68 pre-existing warnings in
overviewReportHelper.js. The focused suite passes all 8 tests. The repository pre-commit related-test run passed 6 of 7 suites; the unrelatedreasonSchedulingControllerintegration suite failed because its database connection timed out.