Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/controllers/communityController.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const communityMemberController = function () {
const { userInfo, frontend, backend, general } = member;
return {
_id: member._id,
userId: member.user_id,
name: userInfo?.name || 'N/A',
email: userInfo?.email || 'N/A',
slack: userInfo?.slack || '',
Expand Down
38 changes: 38 additions & 0 deletions src/controllers/communityController.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
jest.mock('../models/hgnFormResponse');

const FormResponse = require('../models/hgnFormResponse');
const communityMemberController = require('./communityController');

describe('communityController', () => {
it('preserves the response _id and exposes userId from user_id', async () => {
FormResponse.find.mockReturnValue({
lean: jest.fn().mockReturnThis(),
sort: jest.fn().mockResolvedValue([
{
_id: 'response-1',
user_id: 'profile-1',
userInfo: { name: 'John', email: 'john@example.com', slack: 'john' },
general: { location: 'Remote' },
frontend: { React: '8' },
backend: { MongoDB: '7' },
},
]),
});

const req = { query: {} };
const res = { json: jest.fn(), status: jest.fn().mockReturnThis() };

await communityMemberController().getCommunityMembers(req, res);

expect(res.json).toHaveBeenCalledWith([
expect.objectContaining({
_id: 'response-1',
userId: 'profile-1',
name: 'John',
email: 'john@example.com',
slack: 'john',
team: 'Remote',
}),
]);
});
});
1 change: 1 addition & 0 deletions src/controllers/hgnFormResponseController.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ const hgnFormController = () => {

return {
_id: user._id,
userId: user.user_id,
name: user.userInfo?.name,
email: user.userInfo?.email,
slack: user.userInfo?.slack,
Expand Down
3 changes: 2 additions & 1 deletion src/controllers/hgnFormResponseController.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ describe('HgnFormResponseController', () => {

expect(FormResponse.find).toHaveBeenCalled();
expect(result[0]._id).toBe('2'); // Jane should be ranked higher
expect(result[0].userId).toBe('456');
expect(result[0].topSkills).toEqual(expect.arrayContaining(['React']));
expect(result[1]._id).toBe('1');
});
Expand Down Expand Up @@ -207,7 +208,7 @@ describe('HgnFormResponseController', () => {
expect(mockRes.json).toHaveBeenCalledWith(
expect.arrayContaining([
expect.objectContaining({ _id: '1' }),
expect.objectContaining({ _id: '2' }),
expect.objectContaining({ _id: '2', userId: '456' }),
]),
);
});
Expand Down
Loading