Skip to content

Backport extra sequencer metrics #4316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
magicxyyz wants to merge 8 commits into
base: experimental-l2message-size
Choose a base branch
from
Draft

Backport extra sequencer metrics #4316

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e28370b
add sequencer tx size metrics
magicxyyz Feb 2, 2026
cd08f0f
add sequencer queue metrics
magicxyyz Feb 3, 2026
517d5e7
add before block sequencer queue len histogram metrics
magicxyyz Feb 3, 2026
5e2e980
add counters for early ended blocks
magicxyyz Feb 3, 2026
1a82976
add waitfortx sequencer metric
magicxyyz Feb 3, 2026
9686ff1
update sequencer metrics, remove timeboost specific ones
magicxyyz Feb 4, 2026
17d1af0
fix updating seq qeueue length metrics, improve end of block metrics
magicxyyz Feb 4, 2026
7868f4d
fix gasLimitedBlocksCounter metric
magicxyyz Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 45 additions & 4 deletions execution/gethexec/sequencer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ import (

var (
sequencerBacklogGauge = metrics.NewRegisteredGauge("arb/sequencer/backlog", nil)
sequencerQueueGauge = metrics.NewRegisteredGauge("arb/sequencer/queue/length", nil)
sequencerQueueHistogram = metrics.NewRegisteredHistogram("arb/sequencer/queue/histogram", nil, metrics.NewBoundedHistogramSample())
nonceCacheHitCounter = metrics.NewRegisteredCounter("arb/sequencer/noncecache/hit", nil)
nonceCacheMissCounter = metrics.NewRegisteredCounter("arb/sequencer/noncecache/miss", nil)
nonceCacheRejectedCounter = metrics.NewRegisteredCounter("arb/sequencer/noncecache/rejected", nil)
Expand All @@ -54,12 +56,21 @@ var (
nonceFailureCacheOverflowCounter = metrics.NewRegisteredCounter("arb/sequencer/noncefailurecache/overflow", nil)
blockCreationTimer = metrics.NewRegisteredHistogram("arb/sequencer/block/creation", nil, metrics.NewBoundedHistogramSample())
successfulBlocksCounter = metrics.NewRegisteredCounter("arb/sequencer/block/successful", nil)
blockTxSizeHistogram = metrics.NewRegisteredHistogram("arb/sequencer/block/txsize", nil, metrics.NewBoundedHistogramSample())
Comment thread
eljobe marked this conversation as resolved.
txSizeHistogram = metrics.NewRegisteredHistogram("arb/sequencer/transactions/txsize", nil, metrics.NewBoundedHistogramSample())
conditionalTxRejectedBySequencerCounter = metrics.NewRegisteredCounter("arb/sequencer/conditionaltx/rejected", nil)
conditionalTxAcceptedBySequencerCounter = metrics.NewRegisteredCounter("arb/sequencer/conditionaltx/accepted", nil)
l1GasPriceGauge = metrics.NewRegisteredGauge("arb/sequencer/l1gasprice", nil)
callDataUnitsBacklogGauge = metrics.NewRegisteredGauge("arb/sequencer/calldataunitsbacklog", nil)
currentSurplusGauge = metrics.NewRegisteredGauge("arb/sequencer/currentsurplus", nil)
expectedSurplusGauge = metrics.NewRegisteredGauge("arb/sequencer/expectedsurplus", nil)
waitForTxHistogram = metrics.NewRegisteredHistogram("arb/sequencer/waitfortx", nil, metrics.NewBoundedHistogramSample())
// number of blocks ended because of block gas limit at least one tx wasn't included in block because of gas limit)
gasLimitedBlocksCounter = metrics.NewRegisteredCounter("arb/sequencer/block/gaslimited", nil)
// number of blocks ended because of txes data size limit
dataLimitedBlocksCounter = metrics.NewRegisteredCounter("arb/sequencer/block/datalimited", nil)
// number of blocks ended because of exhausting the transactions to sequence
txExhaustedBlocksCounter = metrics.NewRegisteredCounter("arb/sequencer/block/txexhausted", nil)
)

type SequencerConfig struct {
Expand Down Expand Up @@ -716,7 +727,6 @@ func (s *Sequencer) publishTransactionToQueue(queueCtx context.Context, tx *type
case <-queueCtx.Done():
return queueCtx.Err()
}

return nil
}

Expand Down Expand Up @@ -919,6 +929,7 @@ type FullSequencingHooks struct {
preTxFilter func(*params.ChainConfig, *types.Header, *state.StateDB, *arbosState.ArbosState, *types.Transaction, *arbitrum_types.ConditionalOptions, common.Address, *arbos.L1Info) error
postTxFilter func(*types.Header, *state.StateDB, *arbosState.ArbosState, *types.Transaction, common.Address, uint64, *core.ExecutionResult) error
blockFilter func(*types.Header, *state.StateDB, types.Transactions, types.Receipts) error
txSizeLimitReached bool
}

func (s *FullSequencingHooks) MessageFromTxes(header *arbostypes.L1IncomingMessageHeader) (*arbostypes.L1IncomingMessage, error) {
Expand Down Expand Up @@ -990,6 +1001,7 @@ func (s *FullSequencingHooks) NextTxToSequence() (*types.Transaction, *arbitrum_
if s.sequencedTxsSizeSoFar+s.queueItems[s.sequencedQueueItemsCount].txSize > s.maxSequencedTxsSize {
s.sequencedQueueItemsCount += 1
s.InsertLastTxError(core.ErrGasLimitReached)
s.txSizeLimitReached = true
} else {
s.sequencedQueueItemsCount += 1
break
Expand Down Expand Up @@ -1219,11 +1231,23 @@ func (s *Sequencer) createBlock(ctx context.Context) (returnValue bool) {
}
}()

var startOfReadingFromTxQueue time.Time
txQueueLen := int64(len(s.txQueue))
sequencerQueueGauge.Update(txQueueLen)
sequencerQueueHistogram.Update(txQueueLen)

var startOfReadingFromTxQueue time.Time
startOfBlockCreation := time.Now()
for {
if len(queueItems) == 1 {
startOfReadingFromTxQueue = time.Now()
waitForFirstTx := time.Since(startOfBlockCreation)
if waitForFirstTx < time.Millisecond {
// we don't care about the first iteration duration
// so to keep history clean we sanitize waits shorter then ms to 0
waitForTxHistogram.Update(0)
} else {
waitForTxHistogram.Update(int64(waitForFirstTx))
}
} else if len(queueItems) > 1 && time.Since(startOfReadingFromTxQueue) > config.ReadFromTxQueueTimeout {
break
}
Expand Down Expand Up @@ -1321,9 +1345,10 @@ func (s *Sequencer) createBlock(ctx context.Context) (returnValue bool) {
s.nonceCache.BeginNewBlock()
queueItems = s.precheckNonces(queueItems)
timeboostedTxs := make(map[common.Hash]struct{})
maxTxDataSize := s.config().MaxTxDataSize
hooks := MakeSequencingHooks(
queueItems,
s.config().MaxTxDataSize,
maxTxDataSize,
s.preTxFilter,
s.postTxFilter,
nil,
Expand Down Expand Up @@ -1430,14 +1455,19 @@ func (s *Sequencer) createBlock(ctx context.Context) (returnValue bool) {
}

madeBlock := false
var blockTxSize int64
blockGasLimitReached := false
for i, err := range hooks.txErrors {
queueItem := queueItems[i]
if err == nil {
madeBlock = true
blockTxSize += int64(queueItem.txSize)
txSizeHistogram.Update(int64(queueItem.txSize))
}
queueItem := queueItems[i]
if errors.Is(err, core.ErrGasLimitReached) {
// There's not enough gas left in the block for this tx.
if madeBlock {
blockGasLimitReached = true
// There was already an earlier tx in the block; retry in a fresh block.
s.txRetryQueue.Push(queueItem)
continue
Expand All @@ -1454,6 +1484,17 @@ func (s *Sequencer) createBlock(ctx context.Context) (returnValue bool) {
}
queueItem.returnResult(err)
}
if madeBlock {
blockTxSizeHistogram.Update(blockTxSize)
if hooks.txSizeLimitReached {
dataLimitedBlocksCounter.Inc(1)
} else if blockGasLimitReached {
gasLimitedBlocksCounter.Inc(1)
} else {
// no transactions were skipped due to block size or gas limit
txExhaustedBlocksCounter.Inc(1)
}
}
return madeBlock
}

Expand Down
Loading