ethapi: set simulateV1 timestampIncrement to 0 for Arbitrum - #667
Open
blockchain-dev-tools wants to merge 2 commits into
Open
ethapi: set simulateV1 timestampIncrement to 0 for Arbitrum#667blockchain-dev-tools wants to merge 2 commits into
blockchain-dev-tools wants to merge 2 commits into
Conversation
Arbitrum produces a block every 250ms. At second granularity (geth's uint64 timestamp), 250ms rounds to 0, so consecutive simulated blocks share the same timestamp. The previous default of 12 (Ethereum's L1 block time) was incorrect for Arbitrum L2 simulation. nitro references this repo as a git submodule; eth_simulateV1's default timestamp increment should reflect Arbitrum's 250ms block time, not Ethereum's 12s.
|
|
Preserve the upstream 12-second default for non-Arbitrum chains while using a zero-second increment for Arbitrum's sub-second block cadence. Add coverage for default blocks, gap filling, and explicit timestamp overrides. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <<EMAIL_ADDRESS>>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arbitrum produces a block every 250ms. At second granularity (geth's uint64 timestamp), 250ms rounds to 0, so consecutive simulated blocks share the same timestamp. The previous default of 12 (Ethereum's L1 block time) was incorrect for Arbitrum L2 simulation.
nitro references this repo as a git submodule; eth_simulateV1's default timestamp increment should reflect Arbitrum's 250ms block time, not Ethereum's 12s.