Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4806 +/- ##
==========================================
+ Coverage 67.72% 67.81% +0.08%
==========================================
Files 255 255
Lines 33711 33808 +97
==========================================
+ Hits 22832 22928 +96
- Misses 10878 10879 +1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
putBytesN zero-padded short values, so for example 20 byte withdrawal credentials hashed the same as their padded 32 byte form and passed lock verification. Fixed size definition and lock fields must now be empty or exactly the right length, checked by VerifyHashes and when hashing. Lock aggregate and node signature lengths are checked by VerifySignatures. Unmarshalling stays lenient so --no-verify can still load such a lock. Adds --no-verify to exit sign, fetch and broadcast so operators can still exit with a lock that fails verification; exit messages are still verified by the Obol API and the beacon chain. category: bug ticket: none
OisinKyne
force-pushed
the
oisin/strict-lock-verification
branch
from
November 4, 2026 01:32
a1e76b1 to
35bce88
Compare
|
OisinKyne
changed the title
KaloyanTanev
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
putBytesNused to zero-pad short values, so, for example, 20-byte withdrawal credentials hashed the same as their padded 32-byte form and passed lock verification. Fixed-size fields in definitions and locks must now be empty or exactly the right length. This is checked inVerifyHashesand when hashing, not when unmarshalling, so--no-verifystill loads such a lock. The lock aggregate and node signature lengths are checked inVerifySignatures.Adds
--no-verifytoexit sign,exit fetchandexit broadcast, so an operator whose lock fails verification can still exit. Exit messages are still verified by the Obol API and the beacon chain. The golden lock testdata is updated to use real-length signatures. The hashes are unchanged.The deposit data, registration and address checks and the spec test vectors that used to be in this PR have moved to follow-ups.
category: bug
ticket: none