Skip to content

added none values for retrofit and shapeirregularity - #257

Merged
benhayes21 merged 4 commits into
release/v5.0.0from
fix/246-none-retrofit-shapeirregularity
Dec 18, 2025
Merged

benhayes21 merged 4 commits into
release/v5.0.0from
fix/246-none-retrofit-shapeirregularity

Conversation

@benhayes21

Copy link
Copy Markdown
Contributor

fixes #246

None Values

Add none values for retrofit and shape irregularity fields

@github-actions

Copy link
Copy Markdown

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit e75bc5c
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/19294843837
Excel File excel_spec.zip
JSON File extracted_spec.zip

@github-actions

Copy link
Copy Markdown

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit 098d6a3
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/20268674827
Excel File excel_spec.zip
JSON File extracted_spec.zip

sambles and others added 2 commits December 16, 2025 13:14
ODS-tools dropped py3.8 as its out of support, the package now has
syntax that fails tests with that version OasisLMF/ODS_Tools#176
Align schema tests with that change.
@github-actions

Copy link
Copy Markdown

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit 6f26519
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/20269228780
Excel File excel_spec.zip
JSON File extracted_spec.zip

@benhayes21
benhayes21 merged commit 4b48ae3 into release/v5.0.0 Dec 18, 2025
8 checks passed
@benhayes21 benhayes21 mentioned this pull request Dec 18, 2025
sambles added a commit that referenced this pull request Feb 3, 2026
* added none values for retrofit and shapeirregularity

* retest

* Drop Py3.8 (#264)

ODS-tools dropped py3.8 as its out of support, the package now has
syntax that fails tests with that version OasisLMF/ODS_Tools#176
Align schema tests with that change.

---------

Co-authored-by: Ben Hayes <benhayes@benhayes.lan>
Co-authored-by: Sam Gamble <hexadessa@gmail.com>
Co-authored-by: sambles <sambles@users.noreply.github.com>
@awsbuild awsbuild added this to the 5.0.0 milestone Feb 3, 2026
@sambles
sambles deleted the fix/246-none-retrofit-shapeirregularity branch July 30, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants