Skip to content

Update MASTG-KNOW-0036 and implement MASTG-TEST-0287#3706

Merged
cpholguera merged 18 commits into
masterfrom
cpholguera-patch-2
Jun 4, 2026
Merged

Update MASTG-KNOW-0036 and implement MASTG-TEST-0287#3706
cpholguera merged 18 commits into
masterfrom
cpholguera-patch-2

Conversation

@cpholguera

Copy link
Copy Markdown
Collaborator

Clarified the usage of EncryptedSharedPreferences and added a link to its source code. Updated the warning regarding the Jetpack security crypto library deprecation.

Clarified the usage of EncryptedSharedPreferences and added a link to its source code. Updated the warning regarding the Jetpack security crypto library deprecation.
@cpholguera

Copy link
Copy Markdown
Collaborator Author

@copilot create the content for tests-beta/android/MASVS-STORAGE/MASTG-TEST-0287.md and remove status and note.

Copilot AI commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

@cpholguera I've opened a new pull request, #3707, to work on those changes. Once the pull request is ready, I'll request review from you.

cpholguera and others added 2 commits February 13, 2026 19:04
…3707)

* Initial plan

* Create content for MASTG-TEST-0287 and remove status/note fields

Co-authored-by: cpholguera <29175115+cpholguera@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: cpholguera <29175115+cpholguera@users.noreply.github.com>
@cpholguera cpholguera changed the title Update MASTG-KNOW-0036 with EncryptedSharedPreferences links Update MASTG-KNOW-0036 and implement MASTG-TEST-0287 Feb 13, 2026
@cpholguera
cpholguera marked this pull request as draft February 13, 2026 18:14
Comment thread tests-beta/android/MASVS-STORAGE/MASTG-TEST-0287.md Outdated
@cpholguera
cpholguera marked this pull request as ready for review April 14, 2026 07:25
@cpholguera
cpholguera requested a review from jacobocasado April 14, 2026 07:25
Comment thread knowledge/android/MASVS-STORAGE/MASTG-KNOW-0036.md
Comment thread knowledge/android/MASVS-STORAGE/MASTG-KNOW-0036.md Outdated
Comment thread tests-beta/android/MASVS-STORAGE/MASTG-TEST-0287.md Outdated
Comment thread best-practices/MASTG-BEST-0x31.md Outdated
Comment thread best-practices/MASTG-BEST-0x31.md Outdated
Comment thread best-practices/MASTG-BEST-0x31.md Outdated
Comment thread knowledge/android/MASVS-STORAGE/MASTG-KNOW-0036.md Outdated
@jacobocasado

Copy link
Copy Markdown
Collaborator

For knowledge/android/MASVS-STORAGE/MASTG-KNOW-0036.md, GitHub does not let me attach suggestion blocks to the unchanged intro lines, but I would also update them as follows:

The [`SharedPreferences`](https://developer.android.com/training/data-storage/shared-preferences "Shared Preferences") API is commonly used to permanently save small collections of key-value pairs in the app's sandbox storage.
Since Android 4.2 (API level 17), the `SharedPreferences` object can only be declared private and not world-readable, i.e., accessible to all apps. However, values stored in `SharedPreferences` are written to plain-text XML files in the app sandbox, so they can be extracted if the app data directory becomes accessible, for example through device compromise, backup extraction, or physical access to rooted or unlocked devices.

Comment thread knowledge/android/MASVS-STORAGE/MASTG-KNOW-0036.md Outdated
Comment thread knowledge/android/MASVS-STORAGE/MASTG-KNOW-0036.md Outdated
Comment thread knowledge/android/MASVS-STORAGE/MASTG-KNOW-0036.md Outdated
Comment thread knowledge/android/MASVS-STORAGE/MASTG-KNOW-0036.md Outdated
Comment thread tests-beta/android/MASVS-STORAGE/MASTG-TEST-0287.md Outdated
Comment thread tests-beta/android/MASVS-STORAGE/MASTG-TEST-0287.md Outdated
Comment thread tests-beta/android/MASVS-STORAGE/MASTG-TEST-0287.md Outdated
Comment thread tests-beta/android/MASVS-STORAGE/MASTG-TEST-0287.md
Comment thread tests-beta/android/MASVS-STORAGE/MASTG-TEST-0287.md
Comment thread tests-beta/android/MASVS-STORAGE/MASTG-TEST-0287.md Outdated
Comment thread tests-beta/android/MASVS-STORAGE/MASTG-TEST-0287.md Outdated
Comment thread tests-beta/android/MASVS-STORAGE/MASTG-TEST-0287.md Outdated
Comment thread tests-beta/android/MASVS-STORAGE/MASTG-TEST-0287.md Outdated
Comment thread demos/android/MASVS-STORAGE/MASTG-DEMO-0059/MASTG-DEMO-0059.md
Comment thread demos/android/MASVS-STORAGE/MASTG-DEMO-0059/MASTG-DEMO-0059.md Outdated
Comment thread demos/android/MASVS-STORAGE/MASTG-DEMO-0059/MASTG-DEMO-0059.md Outdated
Comment thread demos/android/MASVS-STORAGE/MASTG-DEMO-0059/MASTG-DEMO-0059.md Outdated
Comment thread demos/android/MASVS-STORAGE/MASTG-DEMO-0059/MASTG-DEMO-0059.md Outdated
Comment thread demos/android/MASVS-STORAGE/MASTG-DEMO-0059/MASTG-DEMO-0059.md Outdated

@jacobocasado jacobocasado left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all changed files from this PR :)

Comment thread knowledge/android/MASVS-STORAGE/MASTG-KNOW-0036.md Outdated
cpholguera and others added 3 commits June 2, 2026 14:56
Co-authored-by: Jaco <43786394+jacobocasado@users.noreply.github.com>
Co-authored-by: Jaco <43786394+jacobocasado@users.noreply.github.com>
Comment thread best-practices/MASTG-BEST-0x31.md Outdated
cpholguera and others added 8 commits June 4, 2026 09:59
Co-authored-by: Jaco <43786394+jacobocasado@users.noreply.github.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Jaco <43786394+jacobocasado@users.noreply.github.com>
…lidating sensitive data storage in SharedPreferences
@cpholguera
cpholguera merged commit ec345c3 into master Jun 4, 2026
10 checks passed
@cpholguera
cpholguera deleted the cpholguera-patch-2 branch June 4, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants