Skip to content

Add resolve spack dependency#485

Closed
nkoukpaizan wants to merge 56 commits into
alex/rosenbrockfrom
nicholson/add-resolve-spack-dependency
Closed

Add resolve spack dependency#485
nkoukpaizan wants to merge 56 commits into
alex/rosenbrockfrom
nicholson/add-resolve-spack-dependency

Conversation

@nkoukpaizan

@nkoukpaizan nkoukpaizan commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This adds Re::Solve as a dependency to the GriKit Spack package.
Draft, because I am not convinced this is such a great idea. But this will at least test #479 in CI.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • [N/A] The new code follows GridKit™ style guidelines.
  • [N/A] There are unit tests for the new code.
  • [N/A] The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

alexander-novo and others added 30 commits July 9, 2026 12:30
@alexander-novo
Add rosenbrock
80c25b3
@alexander-novo
Add rosenbrock tests
86bd50f
@alexander-novo
Fixed bug setting alpha coefficient in rosenbrock
5958ec5
@alexander-novo
Removed extra move
5f84a3e 
Allowing for the possibility of return values optimization
@alexander-novo
Remove some debug outputs
e0d59a5
@alexander-novo
Properly reset stats in initializeSimulation
74667a2
@alexander-novo
Switch back to klu solver
1c36cdd
@alexander-novo
Add empirical order testing
8d2c6d3 
Also properly configure the max_steps parameter
@alexander-novo
Fix dense output indexing issue
3573af2
@alexander-novo
Add RODAS5P tableau
c2affd2
@alexander-novo
Add rodas5p order test
571c40d
@alexander-novo
Add error checking
68ae855
@alexander-novo
Re-organize rosenbrock implementation code
dfffd89
@alexander-novo
Add embedded coefficients for rodas5p
4a5b552
@alexander-novo
Documentation and organization
ed67764
@alexander-novo
Fix cmake when resolve not enabled
1a6e5cd
@alexander-novo
Fix some documentation mistakes
8fb85c0
@alexander-novo
Make error_estimator_stage more ergonomic
0877bb1
@alexander-novo
Move documentation
7f58f4e
@alexander-novo
More documentation
75bf982
@alexander-novo
Update ReSolve dependency
6fe9ffb
@alexander-novo
Code review documentation changes
7489ac3
@alexander-novo
Changes from review
42138ec
@alexander-novo
Fix compiler errors and warnings on g++
9b566e8
@alexander-novo
Apply pre-commit fixes
8f86681
@alexander-novo
fix cmake issue
b80e8fd
@alexander-novo
Update Rosenbrock to use GridKit Vector and VectorHandler
815e1d2
@alexander-novo
Apply pre-commit fixes
7bb47e2
@alexander-novo
[skip ci] Update Documentation
4830cb3
@alexander-novo
Add to changelog
cd9e7b8
@nkoukpaizan
nkoukpaizan force-pushed the nicholson/add-resolve-spack-dependency branch from f994e67 to 2d7ac52 Compare July 10, 2026 19:15
@nkoukpaizan nkoukpaizan self-assigned this Jul 10, 2026
@nkoukpaizan
nkoukpaizan force-pushed the nicholson/add-resolve-spack-dependency branch from 2d7ac52 to b64802f Compare July 10, 2026 19:38
@alexander-novo

alexander-novo commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

@nkoukpaizan I updated the Re::Solve dependency and we should be working again.

@nkoukpaizan
nkoukpaizan force-pushed the nicholson/add-resolve-spack-dependency branch from b64802f to 461b721 Compare July 10, 2026 20:31
alexander-novo
alexander-novo approved these changes Jul 10, 2026
View reviewed changes
Comment thread buildsystem/spack_repo/gridkit/packages/gridkit/package.py Outdated
@nkoukpaizan
nkoukpaizan force-pushed the nicholson/add-resolve-spack-dependency branch from 461b721 to df5e232 Compare July 11, 2026 13:45
@alexander-novo

alexander-novo commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@pelesh There is a leak in SystemSolver::setMatrix being reported here

EDIT: this is being fixed in a PR in ReSolve

@nkoukpaizan
nkoukpaizan force-pushed the nicholson/add-resolve-spack-dependency branch from fc09661 to a54b25d Compare July 13, 2026 19:24
@nkoukpaizan
nkoukpaizan force-pushed the nicholson/add-resolve-spack-dependency branch from a54b25d to 5df02ed Compare July 13, 2026 19:33
@nkoukpaizan
nkoukpaizan force-pushed the nicholson/add-resolve-spack-dependency branch from d8616a1 to b08dc41 Compare July 13, 2026 20:06
@nkoukpaizan

nkoukpaizan commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

Closing for now. Will reopen targeting #489 once rebased and closer to being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-novo alexander-novo alexander-novo approved these changes

Assignees

@nkoukpaizan nkoukpaizan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nkoukpaizan @alexander-novo @shakedregev