Bump the OCaml compiler versions in the CI - #1366
Conversation
This commit introduces three changes: - Bump 4.14.3 to 4.14.4 and 5.4.0 to 5.5.0, - Use major version for the upper bound and minor version for the 4.14, - Quote compiler versions as recommended by the documentation of setup-ocaml.
bclement-ocp
left a comment
There was a problem hiding this comment.
I'm OK with bumping the compiler versions that we use and with restricting to patch versions (i.e. 4.14 instead of 4.14.3), but I'm not sure I'm confident with the major 5 bound — if a new OCaml release accidentally breaks something, that would also brick our CI.
I think new OCaml releases are infrequent enough that we can keep 5.5 (I agree that patch releases are very likely fine) and bump manually it when there is a new minor release?
|
The minimal version for |
|
I'd be fine bumping the minimal version to 4.13 / 4.14 but then we need to do it in the opam files as well — otherwise we risk accidentally using APIs that are not available on older OCaml versions. (I think if we bump the minimal version it should be 4.13 as that is what is still in debian oldstable) Although do we really need to test the |
NOOOOOOOOOOOOOOOO... again a bug of jsoo? |
Apparently ||= is only supported since nodejs 15 (released in 2020) but we are still using an ancient nodejs 14 (?!) in the CI. |
The operator `||=` is introduced in NodeJS 15 (see https://nodejs.org/en/blog/release/v15.0.0). The function `Object.hasOwn` is introduced in NodeJS 16.9.0 (see nodejs/node#41471).
ac3b416 to
f4f7372
Compare
This commit introduces three changes: