[16.0][FIX] shopfloor_mobile: pass remaining quantity across packaging loop iterations - #1268
Open
nicolas-delbovier-acsone wants to merge 1 commit into
Conversation
… iterations When calculating quantities per packaging in `_product_qty_by_packaging`, the initial `qty` parameter was passed to `_qty_by_pkg` at every packaging level without updating the remaining unallocated quantity. As a result, smaller packaging units calculated their required quantity against the full initial amount rather than the remainder left by larger packaging units. This inflated the total calculated in `compute_qty()`, triggering a reactive watcher feedback loop that compounded the total on every tick until overflowing to `NaN`.
Contributor
|
Hi @simahawk, |
lmignon
approved these changes
Sep 11, 2026
lmignon
left a comment
lmignon
left a comment
There was a problem hiding this comment.
😱 An annoying one, and not an easy one to debunk! BTW, the code readability is improved...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug introduced in #1088
When calculating quantities per packaging in
_product_qty_by_packaging, the initialqtyparameter was passed to_qty_by_pkgat every packaging level without updating the remaining unallocated quantity.As a result, smaller packaging units calculated their required quantity against the full initial amount rather than the remainder left by larger packaging units. This inflated the total calculated in
compute_qty(), triggering a reactive watcher feedback loop that compounded the total on every tick until overflowing toNaN.How to reproduce the error
product.packagingfor this productcc @jbaudoux @lmignon